Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding WebHost console logs when developing #10629

Merged
merged 1 commit into from
Nov 14, 2024
Merged

Conversation

brettsam
Copy link
Member

@brettsam brettsam commented Nov 13, 2024

During development, we get console logs from the ScriptHost, but nothing from the WebHost. With this, we'll see similar logs to those we see in Kusto when AZURE_FUNCTIONS_ENVIRONMENT is Development.

Pull request checklist

IMPORTANT: Currently, changes must be backported to the in-proc branch to be included in Core Tools and non-Flex deployments.

  • Backporting to the in-proc branch is not required
    • Otherwise: Link to backporting PR
  • My changes do not require documentation changes
    • Otherwise: Documentation issue linked to PR
  • My changes should not be added to the release notes for the next release
    • Otherwise: I've added my notes to release_notes.md
  • My changes do not need to be backported to a previous version
    • Otherwise: Backport tracked by issue/PR #issue_or_pr
  • My changes do not require diagnostic events changes
    • Otherwise: I have added/updated all related diagnostic events and their documentation (Documentation issue linked to PR)
  • I have added all required tests (Unit tests, E2E tests)

@brettsam brettsam requested a review from a team as a code owner November 13, 2024 22:04
@kshyju
Copy link
Member

kshyju commented Nov 13, 2024

FNH currently use a workaround to strip out the language worker console log prefix , so that the logs appear in the terminal during local development. With this change, I can remove that workaround now.

@brettsam brettsam merged commit 6f7b2d5 into dev Nov 14, 2024
11 checks passed
@brettsam brettsam deleted the bretsam/dev_console branch November 14, 2024 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants