Use IsPackable for ZipPublish.targets #10636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liliankasem
approved these changes
Nov 14, 2024
satvu
approved these changes
Nov 14, 2024
jviau
added a commit
that referenced
this pull request
Nov 18, 2024
jviau
added a commit
that referenced
this pull request
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quick follow up to #10168 to address linux artifacts not packing.
Using
IsZippablewas a last-minute change to avoid zipping up samples. This goes back to usingIsPackable, but suppresses zipping up unintended projects by defaultingIsPackable=falsefor the repo, and opting in only shipping projects totrue.