Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix package problem: update prg_resources to pkgutil #28

Merged
merged 4 commits into from
Jun 24, 2020
Merged

Fix package problem: update prg_resources to pkgutil #28

merged 4 commits into from
Jun 24, 2020

Conversation

arrownj
Copy link
Contributor

@arrownj arrownj commented Jun 24, 2020

No description provided.

Juliehzl
Juliehzl reviewed Jun 24, 2020
View reviewed changes
README.rst
@@ -17,6 +17,10 @@ Handles multi-API versions of Azure Storage Data Plane originally from https://g

Change Log
----------
0.3.5
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could we still use 0.3.4 because previous version is invalid?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm doubting if pypi allow to update the whl only? We can try that.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed with Jianhui, pypi does not support update existing version. So let's just use 0.3.5.

@arrownj arrownj changed the title Fix package problem: update prg_resources to pktutil Fix package problem: update prg_resources to pkgutil Jun 24, 2020
@Juliehzl Juliehzl merged commit 5aa2637 into Azure:master Jun 24, 2020
@bebound
Copy link

bebound commented Nov 7, 2024 •
edited
Loading

This PR forgot to remove __import__('pkg_resources').declare_namespace(__name__) from these files:

azure/multiapi/storagev2/queue/__init__.py
1:__import__('pkg_resources').declare_namespace(__name__)

azure/multiapi/storagev2/blob/__init__.py
1:__import__('pkg_resources').declare_namespace(__name__)

azure/multiapi/storagev2/filedatalake/__init__.py
1:__import__('pkg_resources').declare_namespace(__name__)

azure/multiapi/storagev2/fileshare/__init__.py
1:__import__('pkg_resources').declare_namespace(__name__)

azure/multiapi/cosmosdb/v2017_04_17/__init__.py
1:__import__('pkg_resources').declare_namespace(__name__)

Ref: Azure/azure-cli#27196 (comment)

@bebound bebound mentioned this pull request Nov 7, 2024
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Juliehzl Juliehzl Juliehzl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@arrownj @bebound @Juliehzl