updating vnv and ipam cmdlets #26654

sssharma24 · 2024-11-11T17:53:43Z

Description

Mandatory Checklist

Please choose the target release of Azure PowerShell. (⚠️Target release is a different concept from API readiness. Please click below links for details.)
- General release
- Public preview
- Private preview
- Engineering build
- No need for a release
Check this box to confirm: I have read the Submitting Changes section of CONTRIBUTING.md and reviewed the following information:

SHOULD update ChangeLog.md file(s) appropriately
- For SDK-based development mode, update src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.
  - A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense.
- For autorest-based development mode, include the changelog in the PR description.
- Should not change ChangeLog.md if no new release is required, such as fixing test case only.
SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
SHOULD have proper test coverage for changes in pull request.
SHOULD NOT adjust version of module manually in pull request

azure-client-tools-bot-prd · 2024-11-11T17:53:45Z

️✔️Az.Accounts

️✔️Build

️✔️PowerShell Core - Windows

️✔️Windows PowerShell - Windows

️✔️Az.ApplicationInsights

️✔️Build

️✔️PowerShell Core - Windows

️✔️Windows PowerShell - Windows

️✔️Az.Batch

️✔️Build

️✔️PowerShell Core - Windows

️✔️Windows PowerShell - Windows

️✔️Test

️✔️ - Linux

️✔️ - MacOS

️✔️PowerShell Core - Windows

️✔️Windows PowerShell - Windows

️✔️Az.CognitiveServices

️✔️Build

️✔️PowerShell Core - Windows

️✔️Windows PowerShell - Windows

️✔️Test

️✔️ - Linux

️✔️ - MacOS

️✔️PowerShell Core - Windows

️✔️Windows PowerShell - Windows

️✔️Az.Compute

️✔️Build

️✔️PowerShell Core - Windows

️✔️Windows PowerShell - Windows

️✔️Test

️✔️ - Linux

️✔️ - MacOS

️✔️PowerShell Core - Windows

️✔️Windows PowerShell - Windows

️✔️Az.ContainerRegistry

️✔️Build

️✔️PowerShell Core - Windows

️✔️Windows PowerShell - Windows

️✔️Test

️✔️ - Linux

️✔️ - MacOS

️✔️PowerShell Core - Windows

️✔️Windows PowerShell - Windows

️✔️Az.CosmosDB

️✔️Build

️✔️PowerShell Core - Windows

️✔️Windows PowerShell - Windows

️✔️Test

️✔️ - Linux

️✔️ - MacOS

️✔️PowerShell Core - Windows

️✔️Windows PowerShell - Windows

️✔️Az.DataLakeStore

️✔️Build

️✔️PowerShell Core - Windows

️✔️Windows PowerShell - Windows

️✔️Test

️✔️ - Linux

️✔️ - MacOS

️✔️PowerShell Core - Windows

️✔️Windows PowerShell - Windows

️✔️Az.Dns

️✔️Build

️✔️PowerShell Core - Windows

️✔️Windows PowerShell - Windows

️✔️Test

️✔️ - Linux

️✔️ - MacOS

️✔️PowerShell Core - Windows

️✔️Windows PowerShell - Windows

️✔️Az.EventHub

️✔️Build

️✔️PowerShell Core - Windows

️✔️Windows PowerShell - Windows

️✔️Test

️✔️ - Linux

️✔️ - MacOS

️✔️PowerShell Core - Windows

️✔️Windows PowerShell - Windows

⚠️Az.KeyVault

️✔️Build

️✔️PowerShell Core - Windows

️✔️Windows PowerShell - Windows

⚠️Test

⚠️ - Linux

Type Title Current Coverage Description

⚠️ Test Coverage Less Than 50% 22.09 % Test coverage for the module cannot be lower than 50%.

⚠️ - MacOS

Type Title Current Coverage Description

⚠️ Test Coverage Less Than 50% 22.09% Test coverage for the module cannot be lower than 50%.

⚠️PowerShell Core - Windows

Type Title Current Coverage Description

⚠️ Test Coverage Less Than 50% 22.09% Test coverage for the module cannot be lower than 50%.

⚠️Windows PowerShell - Windows

Type Title Current Coverage Description

⚠️ Test Coverage Less Than 50% 22.09% Test coverage for the module cannot be lower than 50%.

️✔️Az.ManagedServiceIdentity

️✔️Build

️✔️PowerShell Core - Windows

️✔️Windows PowerShell - Windows

⚠️Az.Monitor

️✔️Build

️✔️PowerShell Core - Windows

️✔️Windows PowerShell - Windows

⚠️Test

⚠️ - Linux

Type Title Current Coverage Description

⚠️ Test Coverage Less Than 50% 17.39 % Test coverage for the module cannot be lower than 50%.

⚠️ - MacOS

Type Title Current Coverage Description

⚠️ Test Coverage Less Than 50% 17.39% Test coverage for the module cannot be lower than 50%.

⚠️PowerShell Core - Windows

Type Title Current Coverage Description

⚠️ Test Coverage Less Than 50% 17.39% Test coverage for the module cannot be lower than 50%.

⚠️Windows PowerShell - Windows

Type Title Current Coverage Description

⚠️ Test Coverage Less Than 50% 17.39% Test coverage for the module cannot be lower than 50%.

⚠️Az.NetAppFiles

️✔️Build

️✔️PowerShell Core - Windows

️✔️Windows PowerShell - Windows

⚠️Test

⚠️ - Linux

Type Title Current Coverage Last Coverage Description

⚠️ Test Coverage Less Than 80% 75.00 % 78.87% Test coverage cannot be lower than the number of the last release.

⚠️ - MacOS

Type Title Current Coverage Last Coverage Description

⚠️ Test Coverage Less Than 80% 75.00% 78.87% Test coverage cannot be lower than the number of the last release.

⚠️PowerShell Core - Windows

Type Title Current Coverage Last Coverage Description

⚠️ Test Coverage Less Than 80% 75.00% 78.87% Test coverage cannot be lower than the number of the last release.

⚠️Windows PowerShell - Windows

Type Title Current Coverage Last Coverage Description

⚠️ Test Coverage Less Than 80% 75.00% 78.87% Test coverage cannot be lower than the number of the last release.

❌Az.Network

️✔️Build

️✔️PowerShell Core - Windows

️✔️Windows PowerShell - Windows

🔄Breaking Change Check

🔄PowerShell Core - Windows

🔄Windows PowerShell - Windows

🔄Signature Check

🔄PowerShell Core - Windows

🔄Windows PowerShell - Windows

🔄Help Example Check

🔄PowerShell Core - Windows

🔄Windows PowerShell - Windows

🔄Help File Existence Check

🔄PowerShell Core - Windows

🔄Windows PowerShell - Windows

🔄File Change Check

🔄PowerShell Core - Windows

🔄Windows PowerShell - Windows

🔄UX Metadata Check

🔄PowerShell Core - Windows

🔄Windows PowerShell - Windows

❌Test

❌ - Linux

❌ - MacOS

❌PowerShell Core - Windows

❌Windows PowerShell - Windows

️✔️Az.OperationalInsights

️✔️Build

️✔️PowerShell Core - Windows

️✔️Windows PowerShell - Windows

️✔️Az.PrivateDns

️✔️Build

️✔️PowerShell Core - Windows

️✔️Windows PowerShell - Windows

️✔️Test

️✔️ - Linux

️✔️ - MacOS

️✔️PowerShell Core - Windows

️✔️Windows PowerShell - Windows

️✔️Az.RecoveryServices

️✔️Build

️✔️PowerShell Core - Windows

️✔️Windows PowerShell - Windows

️✔️Test

️✔️ - Linux

️✔️ - MacOS

️✔️PowerShell Core - Windows

️✔️Windows PowerShell - Windows

️✔️Az.Resources

️✔️Build

️✔️PowerShell Core - Windows

️✔️Windows PowerShell - Windows

️✔️Az.Security

️✔️Build

️✔️PowerShell Core - Windows

️✔️Windows PowerShell - Windows

️✔️Test

️✔️ - Linux

️✔️ - MacOS

️✔️PowerShell Core - Windows

️✔️Windows PowerShell - Windows

️✔️Az.ServiceBus

️✔️Build

️✔️PowerShell Core - Windows

️✔️Windows PowerShell - Windows

️✔️Test

️✔️ - Linux

️✔️ - MacOS

️✔️PowerShell Core - Windows

️✔️Windows PowerShell - Windows

️✔️Az.SignalR

️✔️Build

️✔️PowerShell Core - Windows

️✔️Windows PowerShell - Windows

️✔️Test

️✔️ - Linux

️✔️ - MacOS

️✔️PowerShell Core - Windows

️✔️Windows PowerShell - Windows

⚠️Az.Sql

️✔️Build

️✔️PowerShell Core - Windows

️✔️Windows PowerShell - Windows

⚠️Test

⚠️ - Linux

Type Title Current Coverage Last Coverage Description

⚠️ Test Coverage Less Than 80% 62.15 % 62.22% Test coverage cannot be lower than the number of the last release.

⚠️ - MacOS

Type Title Current Coverage Last Coverage Description

⚠️ Test Coverage Less Than 80% 62.15% 62.22% Test coverage cannot be lower than the number of the last release.

⚠️PowerShell Core - Windows

Type Title Current Coverage Last Coverage Description

⚠️ Test Coverage Less Than 80% 62.15% 62.22% Test coverage cannot be lower than the number of the last release.

⚠️Windows PowerShell - Windows

Type Title Current Coverage Last Coverage Description

⚠️ Test Coverage Less Than 80% 62.15% 62.22% Test coverage cannot be lower than the number of the last release.

️✔️Az.Storage

️✔️Build

️✔️PowerShell Core - Windows

️✔️Windows PowerShell - Windows

️✔️Az.Websites

️✔️Build

️✔️PowerShell Core - Windows

️✔️Windows PowerShell - Windows

️✔️Test

️✔️ - Linux

️✔️ - MacOS

️✔️PowerShell Core - Windows

️✔️Windows PowerShell - Windows

…zure-powershell into sssharma/ps-bugbash

VeryEarly

this looks like breaking change to make an optional parameter mandatory. updating the parameter set name won't help

VeryEarly · 2024-11-12T03:42:30Z

please update changelog: https://github.com/sssharma24/azure-powershell/blob/sssharma/ps-bugbash/src/Network/Network/ChangeLog.md

sssharma24 · 2024-11-13T20:21:30Z

this looks like breaking change to make an optional parameter mandatory. updating the parameter set name won't help

which file/cmdlet are you referring to

VeryEarly · 2024-11-15T07:55:38Z

this looks like breaking change to make an optional parameter mandatory. updating the parameter set name won't help

which file/cmdlet are you referring to

azure-powershell/src/Network/Network/NetworkManager/VnetVerifier/GetAzNetworkManagerVerifierWorkspaceReachabilityAnalysisIntentCommand.cs

Lines 35 to 43 in 85820fc

    
                   [Parameter( 
        
                      Mandatory = true, 
        
                      ValueFromPipelineByPropertyName = true, 
        
                      HelpMessage = "The resource name.", 
        
                       ParameterSetName = GetByNameParameterSet)] 
        
                   [ResourceNameCompleter("Microsoft.Network/networkManagers/verifierWorkspaces/reachabilityAnalysisIntents", "ResourceGroupName", "NetworkManagerName", "VerifierWorkspaceName")] 
        
                   [ValidateNotNullOrEmpty] 
        
                   [SupportsWildcards] 
        
                   public virtual string Name { get; set; }

…zure-powershell into sssharma/ps-bugbash

sssharma24 · 2024-11-25T21:34:53Z

this looks like breaking change to make an optional parameter mandatory. updating the parameter set name won't help

I have reverted it to optional

sssharma24 · 2024-11-25T21:35:56Z

please update changelog: https://github.com/sssharma24/azure-powershell/blob/sssharma/ps-bugbash/src/Network/Network/ChangeLog.md

changelog is already updated all of these cmdlets are new and will be added in this release

sssharma24 · 2024-11-25T21:36:17Z

@VeryEarly could you run the pipelines

VeryEarly · 2024-11-26T06:05:42Z

/azp run

azure-pipelines · 2024-11-26T06:05:58Z

Azure Pipelines successfully started running 3 pipeline(s).

VeryEarly · 2024-12-03T10:25:45Z

/azp run

azure-pipelines · 2024-12-03T10:26:02Z

Azure Pipelines successfully started running 3 pipeline(s).

updating cmdlets

3a2a0d9

p-thompson and others added 3 commits November 11, 2024 13:06

update getipampool cmdlet

bbdc7dc

updated all vnv cmdlets

e83f3f0

Merge branch 'sssharma/ps-bugbash' of https://github.com/sssharma24/a…

de86c5c

…zure-powershell into sssharma/ps-bugbash

VeryEarly self-assigned this Nov 12, 2024

VeryEarly reviewed Nov 12, 2024

View reviewed changes

ipam cmdlet update

5218488

revert setipampool changes

85820fc

sssharma24 added 2 commits November 25, 2024 12:12

revert set and add help text

bfd4b11

Merge branch 'sssharma/ps-bugbash' of https://github.com/sssharma24/a…

2a962fc

…zure-powershell into sssharma/ps-bugbash

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

updating vnv and ipam cmdlets #26654

updating vnv and ipam cmdlets #26654

sssharma24 commented Nov 11, 2024 •

edited

Loading

azure-client-tools-bot-prd bot commented Nov 11, 2024 •

edited

Loading

VeryEarly left a comment

VeryEarly commented Nov 12, 2024

sssharma24 commented Nov 13, 2024

VeryEarly commented Nov 15, 2024

sssharma24 commented Nov 25, 2024

sssharma24 commented Nov 25, 2024

sssharma24 commented Nov 25, 2024

VeryEarly commented Nov 26, 2024

azure-pipelines bot commented Nov 26, 2024

VeryEarly commented Dec 3, 2024

azure-pipelines bot commented Dec 3, 2024

updating vnv and ipam cmdlets #26654

Are you sure you want to change the base?

updating vnv and ipam cmdlets #26654

Conversation

sssharma24 commented Nov 11, 2024 • edited Loading

Description

Mandatory Checklist

azure-client-tools-bot-prd bot commented Nov 11, 2024 • edited Loading

VeryEarly left a comment

Choose a reason for hiding this comment

VeryEarly commented Nov 12, 2024

sssharma24 commented Nov 13, 2024

VeryEarly commented Nov 15, 2024

sssharma24 commented Nov 25, 2024

sssharma24 commented Nov 25, 2024

sssharma24 commented Nov 25, 2024

VeryEarly commented Nov 26, 2024

azure-pipelines bot commented Nov 26, 2024

VeryEarly commented Dec 3, 2024

azure-pipelines bot commented Dec 3, 2024

sssharma24 commented Nov 11, 2024 •

edited

Loading

azure-client-tools-bot-prd bot commented Nov 11, 2024 •

edited

Loading