[AppServices] RestoreAzureWebAppSnapshot fetch the data from Microsoft.Web RP similar to other commands #26685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t.Web RP similar to other commands
️✔️Az.Accounts
️✔️Az.Network
️✔️Az.Websites
|
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
LGTM. No mocks/tests to add here? |
There are none defined, also it is understandable as the Snapshots are only available after an hour, tests are hard to define for such. |
VeryEarly
reviewed
Nov 21, 2024
| @@ -21,6 +21,7 @@ | |||
|
|
|||
| ## Version 3.2.2 | |||
| * Fix bug where parameters could not be set to false for `Publish-AzWebApp` | |||
| * Fix the source app retrival from Microsoft.Web RP instead of ARM cache for `RestoreAzureWebAppSnapshot` | |||
There was a problem hiding this comment.
please move this line under line 20
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[AppServices] RestoreAzureWebAppSnapshot fetch the data from Microsoft.Web RP similar to other commands
Description
Currently to fetch the source web app information we rely on Azure Resources API(https://learn.microsoft.com/en-us/rest/api/resources/resources/list?view=rest-resources-2021-04-01).
The problem with above API is that the response is paginated, and filter is applied at backend on the paginated block. So, for example, if customer has 1000 sites, in first batch ARM fetches 100 from RP and applies the filter provided. If no results found, an empty collection is returned with nextLink to further query. If the customers have 1000's of resources, we end up making a lot of calls and get no data. The changes are to simplify that process.
For background, we changed to use ARM cache 5 years ago. This is because during an outage our RP is not functional, but ARM cache can help with required data for restore.
So, the changes still retain such handling but improve by calling to WEB RP to get the required data if it functional. Fallback will be made to ARM cache if WebRP is not functional.
Tested locally
Mandatory Checklist
Please choose the target release of Azure PowerShell. (⚠️ Target release is a different concept from API readiness. Please click below links for details.)
Check this box to confirm: I have read the Submitting Changes section of
CONTRIBUTING.mdand reviewed the following information:ChangeLog.mdfile(s) appropriatelysrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.## Upcoming Releaseheader in the past tense.ChangeLog.mdif no new release is required, such as fixing test case only.