Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Az.codesigning - fix regressions #26801

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Jaxelr
Copy link
Member

@Jaxelr Jaxelr commented Dec 2, 2024

Description

This PR fixes #26764. The current Azure.CodeSigning.Client.CryptoProvider package has been deprecated and rebranded into Azure.Developer.TrustedSigning.CryptoProvider. The functionality is kept, with minor new class names. It also fixes a duplicate error on the Get Eku list.

Tagging @janielMartell for awareness.

Mandatory Checklist

  • SHOULD update ChangeLog.md file(s) appropriately
    • For SDK-based development mode, update src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.
      • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense.
    • For autorest-based development mode, include the changelog in the PR description.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT adjust version of module manually in pull request

By migrating to the rebranded Azure.Developer.TrustedSigning.CryptoProvider
Copy link

azure-client-tools-bot-prd bot commented Dec 2, 2024

️✔️Az.Accounts
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
❌Az.CodeSigning
❌Build
❌PowerShell Core - Windows
Type Code Position Detail
NU1603 D:\a_work\1\s\src\CodeSigning\CodeSigning.Test\CodeSigning.Test.csproj Microsoft.Azure.PowerShell.Cmdlets.CodeSigning depends on Polly (>= 7.2.3.1) but Polly 7.2.3.1 was not found. An approximate best match of Polly 7.2.4 was resolved. [D:\a_work\1\s\artifacts\Azure.PowerShell.sln]
NU1603 D:\a_work\1\s\src\CodeSigning\CodeSigning\CodeSigning.csproj Microsoft.Azure.PowerShell.Cmdlets.CodeSigning depends on Polly (>= 7.2.3.1) but Polly 7.2.3.1 was not found. An approximate best match of Polly 7.2.4 was resolved. [D:\a_work\1\s\artifacts\Azure.PowerShell.sln]
❌Windows PowerShell - Windows
Type Code Position Detail
NU1603 D:\a_work\1\s\src\CodeSigning\CodeSigning\CodeSigning.csproj Microsoft.Azure.PowerShell.Cmdlets.CodeSigning depends on Polly (>= 7.2.3.1) but Polly 7.2.3.1 was not found. An approximate best match of Polly 7.2.4 was resolved. [D:\a_work\1\s\artifacts\Azure.PowerShell.sln]
NU1603 D:\a_work\1\s\src\CodeSigning\CodeSigning.Test\CodeSigning.Test.csproj Microsoft.Azure.PowerShell.Cmdlets.CodeSigning depends on Polly (>= 7.2.3.1) but Polly 7.2.3.1 was not found. An approximate best match of Polly 7.2.4 was resolved. [D:\a_work\1\s\artifacts\Azure.PowerShell.sln]
🔄Breaking Change Check
🔄PowerShell Core - Windows
🔄Windows PowerShell - Windows
🔄Signature Check
🔄PowerShell Core - Windows
🔄Windows PowerShell - Windows
🔄Help File Existence Check
🔄PowerShell Core - Windows
🔄Windows PowerShell - Windows
🔄File Change Check
🔄PowerShell Core - Windows
🔄Windows PowerShell - Windows
🔄UX Metadata Check
🔄PowerShell Core - Windows
🔄Windows PowerShell - Windows
🔄Test
🔄PowerShell Core - Windows
🔄Windows PowerShell - Windows

@VeryEarly VeryEarly self-assigned this Dec 3, 2024
@VeryEarly
Copy link
Contributor

/azp run

Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@VeryEarly
Copy link
Contributor

Hi @Jaxelr , did you try to build the project in your local environment? dependencies don't look correct in pipeline build.

@Jaxelr
Copy link
Member Author

Jaxelr commented Dec 3, 2024

@VeryEarly so I did, and didnt got this error, but Ill take a look, thanks for the callout.

@Jaxelr
Copy link
Member Author

Jaxelr commented Dec 3, 2024

I added back the Polly dependency. That should resolve this issue. Looks like I cant build this pipeline unless I get your intervention? I'll try though.

@Jaxelr
Copy link
Member Author

Jaxelr commented Dec 3, 2024

/azp run

Copy link
Contributor

Commenter does not have sufficient privileges for PR 26801 in repo Azure/azure-powershell

@VeryEarly
Copy link
Contributor

/azp run

Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Az.Codesigning 0.2.0 Invoke-AzCodeSigningCIPolicySigning Method not found
2 participants