-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update sdk vcpkg portfile with VERSION and HEAD_REF #5516
Conversation
Thank you for your contribution @WangWeiLin-MV! We will review the pull request and get back to you soon. |
Thank you so much! - microsoft/vcpkg#38085 (comment) |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Release works as intended - Azure/azure-sdk-vcpkg-betas@e41c4e7
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks quite reasonable to me.
One small question: Why the addition of HEAD_REF?
CI checks failed with It could be fixed by upgrading the |
There is a recommended optional parameter HEAD_REF for This value allows the option --head in command |
Update 18 sdk vcpkg
portfile.cmake
, and updateInitialize-VcpkgRelease.ps1
regex.Reference updates PR microsoft/vcpkg#38085 and microsoft/vcpkg#29514 and daily validation PR microsoft/vcpkg#34835
Changes
sdk\**\vcpkg\portfile.cmake
HEAD_REF
to allow HEAD builds by matching(?<=\s{4})SHA512 0\n\)
withSHA512 0\n HEAD_REF main\n)
REF
to use variable${VERSION}
and be quoted by matching(?<=\s{4})REF (azure.+)@AZ_LIBRARY_VERSION@$
withREF "$1${VERSION}"
REF azure.*
toREF \"azure.*\"
to keep "Overriding REF with test release ref" forPublishDailyVcpkg
in archetype-cpp-release.yml#L266-L302