Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sdk vcpkg portfile with VERSION and HEAD_REF #5516

Merged
merged 6 commits into from
Apr 12, 2024
Merged

Update sdk vcpkg portfile with VERSION and HEAD_REF #5516

merged 6 commits into from
Apr 12, 2024

Conversation

WangWeiLin-MV
Copy link
Contributor

Update 18 sdk vcpkg portfile.cmake, and update Initialize-VcpkgRelease.ps1 regex.

Reference updates PR microsoft/vcpkg#38085 and microsoft/vcpkg#29514 and daily validation PR microsoft/vcpkg#34835

Changes

@github-actions github-actions bot added Attestation Azure.Core Azure.Identity Community Contribution Community members are working on the issue customer-reported Issues that are reported by GitHub users external to the Azure organization. EngSys This issue is impacting the engineering system. Event Hubs KeyVault Storage Storage Service (Queues, Blobs, Files) Tables labels Apr 11, 2024
Copy link

Thank you for your contribution @WangWeiLin-MV! We will review the pull request and get back to you soon.

@antkmsft
Copy link
Member

Thank you so much! - microsoft/vcpkg#38085 (comment)

@antkmsft
Copy link
Member

HEAD_REF is also a good addition. I didn't know that feature existed.
For other reviewers, this enables https://learn.microsoft.com/en-us/vcpkg/commands/install#--head

Copy link
Member

@antkmsft antkmsft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Release works as intended - Azure/azure-sdk-vcpkg-betas@e41c4e7

Copy link
Member

@LarryOsterman LarryOsterman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks quite reasonable to me.

One small question: Why the addition of HEAD_REF?

@WangWeiLin-MV
Copy link
Contributor Author

CI checks failed with CMake version 3.29.1 in microsoft/vcpkg#37968.

It could be fixed by upgrading the CMake version in image pool to 3.29.2, or updating the vcpkg PR microsoft/vcpkg#38144.

@WangWeiLin-MV
Copy link
Contributor Author

This looks quite reasonable to me.

One small question: Why the addition of HEAD_REF?

There is a recommended optional parameter HEAD_REF for vcpkg ports which uses vcpkg_from_github, it generally points the reference of git HEAD and here is branch main.

This value allows the option --head in command vcpkg install --head ${PORT} to fetch the latest sources available when building for "intended for temporary testing".

@antkmsft antkmsft merged commit e148d89 into Azure:main Apr 12, 2024
263 checks passed
@WangWeiLin-MV WangWeiLin-MV deleted the sdk/vcpkg-portfile branch April 15, 2024 02:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Attestation Azure.Core Azure.Identity Community Contribution Community members are working on the issue customer-reported Issues that are reported by GitHub users external to the Azure organization. EngSys This issue is impacting the engineering system. Event Hubs KeyVault Storage Storage Service (Queues, Blobs, Files) Tables
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants