Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify the samples for Tables to avoid using connection string overloads. #6142

Closed
wants to merge 2 commits into from

Conversation

ahsonkhan
Copy link
Contributor

No description provided.

@ahsonkhan ahsonkhan added this to the 2024-11 milestone Oct 29, 2024
@ahsonkhan ahsonkhan requested a review from RickWinter October 29, 2024 04:55
@ahsonkhan ahsonkhan self-assigned this Oct 29, 2024
@ahsonkhan
Copy link
Contributor Author

/azp run cpp - tables

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

@ahsonkhan ahsonkhan requested a review from danieljurek October 29, 2024 09:14
@ahsonkhan
Copy link
Contributor Author

ahsonkhan commented Oct 30, 2024

It looks like running the samples inherently rely on the connection string env var, containing the account name and sas token. Ideally, fetching the account name from the env var should work, but it seems to not find the resource:
https://dev.azure.com/azure-sdk/internal/_build/results?buildId=4278186&view=logs&j=ea109acd-b7d3-5ded-4f2b-e0ac8b0c5651&t=82c3d730-b00d-5c6a-3ffd-b86aefe48338&l=276

[2024-10-29T09:08:54.1589490Z T: 140215962841344] INFO  : HTTP status code 404 won't be retried.
terminate called after throwing an instance of 'Azure::Core::RequestFailedException'
  what():  Received an HTTP unsuccessful status code: 404 Reason: The specified resource does not exist.

If I had to guess, there's some resource setup mismatch. cc @danieljurek
I am considering a solution to build the sample but not run it, and file an issue to enabling running it in the future.
The important thing here with samples is encouraging best practices of what we expect/want customers to do.

@LarryOsterman
Copy link
Member

I'm not comfortable checking in samples that we've not verified actually work.

When you run them on your dev client, do they run successfully (in other words, is the error an error in the pipeline configuration, or is it that the entra id stuff doesn't work because of a test-resources issue)?

Is it possible this is as simple as not having a delay in the test-resources to let the entra ID provisioning to replicate (we've had to add a delay to eventhubs and attestation for this reason).

@ahsonkhan
Copy link
Contributor Author

Superseded by #6181

@ahsonkhan ahsonkhan closed this Dec 2, 2024
@ahsonkhan ahsonkhan deleted the UpdateTableSamples branch December 2, 2024 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants