Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally the thought was that the azcore Pager should provide a way to better customize the spans it creates, and that the azcosmos Pager based spans could take advantage of that.
As I was digging it to try to make that work I did realize a few things.
Considering all the above. I think the simplest way to allow azcosmos to customize the tracer used for Pager spans is to not set a tracer in PagingHandler, and allow the custom one within the Fetcher function to take precedence.
For testing, I've pushed a commit with just the tests to show that before this change the tests fail to have the
query_
spans. Then I've pushed the commit that removes setting the Tracer and you can see the tests all pass now.Example of a failing test: