Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrapping exceptions thrown in custom serializers as a CosmosException with StatusCode 400 #40797

Merged
merged 7 commits into from
Jun 26, 2024
Merged

Wrapping exceptions thrown in custom serializers as a CosmosException with StatusCode 400 #40797

merged 7 commits into from
Jun 26, 2024
+385 −27

Conversation

FabianMeiswinkel
Copy link
Member

Description

This PR ensures that any exceptions thrown from custom serializers are wrapped in a CosmosException with Status Code 400

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

jeet1995
jeet1995 approved these changes Jun 25, 2024
View reviewed changes
Copy link
Member

@jeet1995 jeet1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks! Would require a CHANGELOG addition as well.

xinlian12
xinlian12 approved these changes Jun 25, 2024
View reviewed changes
Copy link
Member

@xinlian12 xinlian12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

xinlian12
xinlian12 approved these changes Jun 25, 2024
View reviewed changes
Copy link
Member

@xinlian12 xinlian12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

jeet1995
jeet1995 approved these changes Jun 25, 2024
View reviewed changes
Copy link
Member

@jeet1995 jeet1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM on the latest changes.

@FabianMeiswinkel FabianMeiswinkel merged commit 787a7f6 into Azure:main Jun 26, 2024
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xinlian12 xinlian12 xinlian12 approved these changes

@jeet1995 jeet1995 jeet1995 approved these changes

@kushagraThapar kushagraThapar kushagraThapar approved these changes

@kirankumarkolli kirankumarkolli Awaiting requested review from kirankumarkolli kirankumarkolli is a code owner

@milismsft milismsft Awaiting requested review from milismsft

@aayush3011 aayush3011 Awaiting requested review from aayush3011

@simorenoh simorenoh Awaiting requested review from simorenoh

@Pilchie Pilchie Awaiting requested review from Pilchie

Assignees
No one assigned
Labels
Cosmos
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@FabianMeiswinkel @azure-sdk @kushagraThapar @jeet1995 @xinlian12