Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix token acquisition when using azure-json #42860

Merged
merged 6 commits into from
Nov 11, 2024
Merged

Fix token acquisition when using azure-json #42860

merged 6 commits into from
Nov 11, 2024

Conversation

moarychan
Copy link
Member

Description

Fix JsonParseException and ServiceConfigurationError exceptions.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@github-actions github-actions bot added the azure-spring All azure-spring related issues label Nov 8, 2024
@azure-sdk
Copy link
Collaborator

API change check

APIView has identified API level changes in this PR and created following API reviews.

com.azure:azure-security-keyvault-jca

rujche
rujche approved these changes Nov 11, 2024
View reviewed changes
Copy link
Member

@rujche rujche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@moarychan moarychan merged commit 9b9b3b1 into Azure:main Nov 11, 2024
19 checks passed
mssfang pushed a commit to mssfang/azure-sdk-for-java that referenced this pull request Nov 14, 2024
@moarychan @mssfang
Fix token acquisition when using azure-json and add JCA provider debu…
e93306f 
…g section (Azure#42860)
@moarychan moarychan deleted the bugfixes/convert-to-token-exception-when-using-azure-json branch November 20, 2024 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rujche rujche rujche approved these changes

@saragluna saragluna saragluna approved these changes

@Netyyyy Netyyyy Awaiting requested review from Netyyyy Netyyyy is a code owner

Assignees
No one assigned
Labels
azure-spring All azure-spring related issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@moarychan @azure-sdk @saragluna @rujche