Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CheckStyle-Rule-Extension: 6, 7, 8 #4339

Merged
merged 48 commits into from
Jul 23, 2019

Conversation

mssfang
Copy link
Member

@mssfang mssfang commented Jul 9, 2019

  • Check 6: @ServiceClientBuilder
    • All service client builder should be named ClientBuilder and annotated with @ServiceClientBuilder.
    • Has a method 'buildClient()' to build a synchronous client,
    • Has a method 'buildAsyncClient()' to build an asynchronous client
  • Check 7: @ServiceInterface
    • The annotation property 'name' should be non-empty
    • The length of value of property 'name' should be less than 20 characters and without space
  • Check 8: No OpenCensus dependency
    • OpenCensus should only be depended on from within the tracing-opencensus module. It should not be used in any other class throughout the Java SDK.

@mssfang
Copy link
Member Author

mssfang commented Jul 12, 2019

No 9 is still experiencing the IO exception failed which is the same problem about reflection. But the existing rule implementation is ready for review.

@conniey
Copy link
Member

conniey commented Jul 12, 2019

I think these checks might have to be split up into another PR. (ie. Check 9 about logAndThrow will result in a PR that touches many files.)

@mssfang mssfang force-pushed the CS-Rule-Builder-Interface branch from d6d9dee to aba32d2 Compare July 12, 2019 06:27
@mssfang mssfang changed the title CheckStyle-Rule-Extension: 6, 7, 8, 9 CheckStyle-Rule-Extension: 6, 7, 8 Jul 12, 2019
@mssfang mssfang requested a review from g2vinay July 12, 2019 17:42
@mssfang mssfang requested a review from JonathanGiles July 12, 2019 21:34
@mssfang
Copy link
Member Author

mssfang commented Jul 12, 2019

Cleaned up and ready for review again. :>

@mssfang mssfang removed the request for review from g2vinay July 18, 2019 17:02
@mssfang
Copy link
Member Author

mssfang commented Jul 22, 2019

PR is ready for reviewing again

Copy link
Member

@JonathanGiles JonathanGiles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with one change requested first.

Copy link
Member

@srnagar srnagar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mssfang mssfang merged commit 7b18d30 into Azure:master Jul 23, 2019
@mssfang mssfang deleted the CS-Rule-Builder-Interface branch July 23, 2019 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants