[engsys] replace dev dependency nyc with c8

***NO_CI*** The combination of `nyc` + `esm` is broken in latest versions of NodeJS (istanbuljs/nyc#1530 (comment)). Since `esm` package is not actively maintained and its repo is archived, it's less likely that the issue will be fixed. This PR switches to use another code coverage tool `c8` which is not affected. `c8` also respects `.nycrc` config files so those are not renamed in this PR.
Azure · Oct 23, 2023 · 78a895f · 78a895f
1 parent f0ff24f
commit 78a895f
Show file tree

Hide file tree

Showing 103 changed files with 343 additions and 209 deletions.
diff --git a/common/config/rush/pnpm-lock.yaml b/common/config/rush/pnpm-lock.yaml
diff --git a/common/tools/dev-tool/src/commands/run/testNodeJSInput.ts b/common/tools/dev-tool/src/commands/run/testNodeJSInput.ts
@@ -33,7 +33,7 @@ export default leafCommand(commandInfo, async (options) => {
     ? updatedArgs?.join(" ")
     : '--timeout 5000000 "dist-esm/test/{,!(browser)/**/}/*.spec.js"';
   const command = {
-    command: `mocha ${defaultMochaArgs} ${mochaArgs}`,
+    command: `c8 mocha ${defaultMochaArgs} ${mochaArgs}`,
     name: "node-tests",
   };
 

diff --git a/sdk/agrifood/agrifood-farming-rest/package.json b/sdk/agrifood/agrifood-farming-rest/package.json
@@ -121,7 +121,7 @@
     "mkdirp": "^1.0.4",
     "mocha-junit-reporter": "^2.0.0",
     "mocha": "^10.0.0",
-    "nyc": "^15.0.0",
+    "c8": "^8.0.0",
     "prettier": "^2.5.1",
     "rimraf": "^3.0.0",
     "source-map-support": "^0.5.9",

diff --git a/sdk/anomalydetector/ai-anomaly-detector-rest/package.json b/sdk/anomalydetector/ai-anomaly-detector-rest/package.json
@@ -101,7 +101,7 @@
     "karma-source-map-support": "~1.4.0",
     "karma-sourcemap-loader": "^0.3.8",
     "karma": "^6.2.0",
-    "nyc": "^15.0.0",
+    "c8": "^8.0.0",
     "csv-parse": "^5.0.3",
     "ts-node": "^10.0.0",
     "esm": "^3.2.18"

diff --git a/sdk/apimanagement/api-management-custom-widgets-scaffolder/package.json b/sdk/apimanagement/api-management-custom-widgets-scaffolder/package.json
@@ -78,7 +78,7 @@
     "mocha": "^10.0.0",
     "mocha-junit-reporter": "^2.0.0",
     "prettier": "^2.5.1",
-    "nyc": "^15.0.0",
+    "c8": "^8.0.0",
     "rimraf": "^3.0.0",
     "ts-node": "^10.0.0",
     "typescript": "~5.0.0",

diff --git a/sdk/apimanagement/api-management-custom-widgets-tools/package.json b/sdk/apimanagement/api-management-custom-widgets-tools/package.json
@@ -73,7 +73,7 @@
     "mocha": "^10.0.0",
     "mocha-junit-reporter": "^2.0.0",
     "prettier": "^2.5.1",
-    "nyc": "^15.0.0",
+    "c8": "^8.0.0",
     "rimraf": "^3.0.0",
     "typescript": "~5.0.0",
     "util": "^0.12.1",

diff --git a/sdk/appconfiguration/app-configuration/package.json b/sdk/appconfiguration/app-configuration/package.json
@@ -44,7 +44,6 @@
     "build": "npm run clean && tsc -p . && dev-tool run bundle && api-extractor run --local",
     "check-format": "prettier --list-different --config ../../../.prettierrc.json --ignore-path ../../../.prettierignore \"src/**/*.ts\" \"test/**/*.ts\" \"samples-dev/**/*.ts\" \"*.{js,json}\"",
     "clean": "rimraf dist dist-* types *.tgz *.log",
-    "coverage": "nyc --reporter=lcov --exclude-after-remap=false mocha -t 120000 dist-test/index.js --reporter ../../../common/tools/mocha-multi-reporter.js",
     "execute:samples": "dev-tool samples run samples-dev",
     "extract-api": "tsc -p . && api-extractor run --local",
     "format": "prettier --write --config ../../../.prettierrc.json --ignore-path ../../../.prettierignore \"src/**/*.ts\" \"test/**/*.ts\" \"samples-dev/**/*.ts\" \"*.{js,json}\"",
@@ -123,7 +122,7 @@
     "mocha": "^10.0.0",
     "mocha-junit-reporter": "^2.0.0",
     "nock": "^12.0.3",
-    "nyc": "^15.0.0",
+    "c8": "^8.0.0",
     "prettier": "^2.5.1",
     "rimraf": "^3.0.0",
     "sinon": "^15.0.0",

diff --git a/sdk/appservice/arm-appservice-rest/package.json b/sdk/appservice/arm-appservice-rest/package.json
@@ -109,7 +109,7 @@
     "karma-source-map-support": "~1.4.0",
     "karma-sourcemap-loader": "^0.3.8",
     "karma": "^6.2.0",
-    "nyc": "^15.0.0",
+    "c8": "^8.0.0",
     "ts-node": "^10.0.0",
     "esm": "^3.2.18"
   },

diff --git a/sdk/attestation/attestation/package.json b/sdk/attestation/attestation/package.json
@@ -133,7 +133,7 @@
     "karma-sourcemap-loader": "^0.3.8",
     "mocha": "^10.0.0",
     "mocha-junit-reporter": "^2.0.0",
-    "nyc": "^15.0.0",
+    "c8": "^8.0.0",
     "prettier": "^2.5.1",
     "rimraf": "^3.0.0",
     "safe-buffer": "^5.2.1",

diff --git a/sdk/cognitivelanguage/ai-language-conversations/package.json b/sdk/cognitivelanguage/ai-language-conversations/package.json
@@ -59,7 +59,7 @@
     "karma-source-map-support": "~1.4.0",
     "mocha": "^10.0.0",
     "mocha-junit-reporter": "^2.0.0",
-    "nyc": "^15.0.0",
+    "c8": "^8.0.0",
     "prettier": "^2.5.1",
     "sinon": "^15.0.0",
     "source-map-support": "^0.5.9",

diff --git a/sdk/cognitivelanguage/ai-language-text/package.json b/sdk/cognitivelanguage/ai-language-text/package.json
@@ -131,7 +131,7 @@
     "karma-source-map-support": "~1.4.0",
     "mocha": "^10.0.0",
     "mocha-junit-reporter": "^2.0.0",
-    "nyc": "^15.0.0",
+    "c8": "^8.0.0",
     "prettier": "^2.5.1",
     "rimraf": "^3.0.0",
     "sinon": "^15.0.0",

diff --git a/sdk/cognitivelanguage/ai-language-textauthoring/package.json b/sdk/cognitivelanguage/ai-language-textauthoring/package.json
@@ -84,7 +84,7 @@
     "@azure/eslint-plugin-azure-sdk": "^3.0.0",
     "@azure/test-utils": "^1.0.0",
     "mocha": "^10.0.0",
-    "nyc": "^15.0.0",
+    "c8": "^8.0.0",
     "ts-node": "^10.0.0"
   },
   "homepage": "https://github.com/Azure/azure-sdk-for-js/tree/main/sdk/cognitivelanguage/ai-language-textauthoring/README.md",

diff --git a/sdk/communication/communication-alpha-ids/package.json b/sdk/communication/communication-alpha-ids/package.json
@@ -97,7 +97,7 @@
     "karma-sourcemap-loader": "^0.3.8",
     "mocha": "^10.0.0",
     "mocha-junit-reporter": "^2.0.0",
-    "nyc": "^15.0.0",
+    "c8": "^8.0.0",
     "prettier": "^2.5.1",
     "rimraf": "^3.0.0",
     "sinon": "^15.0.0",

diff --git a/sdk/communication/communication-call-automation/package.json b/sdk/communication/communication-call-automation/package.json
@@ -119,7 +119,7 @@
     "karma-sourcemap-loader": "^0.3.8",
     "mocha": "^10.0.0",
     "mocha-junit-reporter": "^2.0.0",
-    "nyc": "^15.0.0",
+    "c8": "^8.0.0",
     "prettier": "^2.5.1",
     "rimraf": "^3.0.0",
     "sinon": "^15.0.0",

diff --git a/sdk/communication/communication-chat/package.json b/sdk/communication/communication-chat/package.json
@@ -106,7 +106,7 @@
     "karma-sourcemap-loader": "^0.3.8",
     "mocha": "^10.0.0",
     "mocha-junit-reporter": "^2.0.0",
-    "nyc": "^15.0.0",
+    "c8": "^8.0.0",
     "prettier": "^2.5.1",
     "rimraf": "^3.0.0",
     "sinon": "^15.0.0",

diff --git a/sdk/communication/communication-common/package.json b/sdk/communication/communication-common/package.json
@@ -96,7 +96,7 @@
     "karma": "^6.2.0",
     "mocha-junit-reporter": "^2.0.0",
     "mocha": "^10.0.0",
-    "nyc": "^15.0.0",
+    "c8": "^8.0.0",
     "prettier": "^2.5.1",
     "rimraf": "^3.0.0",
     "sinon": "^15.0.0",

diff --git a/sdk/communication/communication-email/package.json b/sdk/communication/communication-email/package.json
@@ -83,7 +83,7 @@
     "karma-sourcemap-loader": "^0.3.8",
     "mocha": "^10.0.0",
     "mocha-junit-reporter": "^2.0.0",
-    "nyc": "^15.0.0",
+    "c8": "^8.0.0",
     "typescript": "~5.0.0",
     "prettier": "^2.5.1",
     "rimraf": "^3.0.0",

diff --git a/sdk/communication/communication-identity/package.json b/sdk/communication/communication-identity/package.json
@@ -136,7 +136,7 @@
     "karma-sourcemap-loader": "^0.3.8",
     "mocha": "^10.0.0",
     "mocha-junit-reporter": "^2.0.0",
-    "nyc": "^15.0.0",
+    "c8": "^8.0.0",
     "prettier": "^2.5.1",
     "process": "^0.11.10",
     "rimraf": "^3.0.0",

diff --git a/sdk/communication/communication-job-router-rest/package.json b/sdk/communication/communication-job-router-rest/package.json
@@ -101,7 +101,7 @@
     "karma-source-map-support": "~1.4.0",
     "karma-sourcemap-loader": "^0.4.0",
     "karma": "^6.2.0",
-    "nyc": "^15.0.0",
+    "c8": "^8.0.0",
     "ts-node": "^10.0.0"
   },
   "homepage": "https://github.com/Azure/azure-sdk-for-js/tree/main/sdk/communication/communication-job-router-rest/README.md",

diff --git a/sdk/communication/communication-job-router/package.json b/sdk/communication/communication-job-router/package.json
@@ -119,7 +119,7 @@
     "karma": "^6.2.0",
     "mocha-junit-reporter": "^1.18.0",
     "mocha": "^10.0.0",
-    "nyc": "^15.0.0",
+    "c8": "^8.0.0",
     "prettier": "^2.5.1",
     "rimraf": "^3.0.0",
     "sinon": "^15.0.0",

diff --git a/sdk/communication/communication-network-traversal/package.json b/sdk/communication/communication-network-traversal/package.json
@@ -132,7 +132,7 @@
     "karma-sourcemap-loader": "^0.3.8",
     "mocha": "^10.0.0",
     "mocha-junit-reporter": "^2.0.0",
-    "nyc": "^15.0.0",
+    "c8": "^8.0.0",
     "prettier": "^2.5.1",
     "rimraf": "^3.0.0",
     "sinon": "^15.0.0",

diff --git a/sdk/communication/communication-phone-numbers/package.json b/sdk/communication/communication-phone-numbers/package.json
@@ -101,7 +101,7 @@
     "karma": "^6.2.0",
     "mocha-junit-reporter": "^2.0.0",
     "mocha": "^10.0.0",
-    "nyc": "^15.0.0",
+    "c8": "^8.0.0",
     "prettier": "^2.5.1",
     "rimraf": "^3.0.0",
     "sinon": "^15.0.0",

diff --git a/sdk/communication/communication-recipient-verification/package.json b/sdk/communication/communication-recipient-verification/package.json
@@ -100,7 +100,7 @@
     "karma-sourcemap-loader": "^0.3.8",
     "mocha": "^10.0.0",
     "mocha-junit-reporter": "^2.0.0",
-    "nyc": "^15.0.0",
+    "c8": "^8.0.0",
     "prettier": "^2.5.1",
     "rimraf": "^3.0.0",
     "sinon": "^15.0.0",

diff --git a/sdk/communication/communication-rooms/package.json b/sdk/communication/communication-rooms/package.json
@@ -56,7 +56,7 @@
     "karma-env-preprocessor": "^0.1.1",
     "mkdirp": "^1.0.4",
     "mocha": "^10.0.0",
-    "nyc": "^15.0.0",
+    "c8": "^8.0.0",
     "prettier": "^2.5.1",
     "rimraf": "^3.0.0",
     "sinon": "^15.0.0",

diff --git a/sdk/communication/communication-short-codes/package.json b/sdk/communication/communication-short-codes/package.json
@@ -100,7 +100,7 @@
     "karma-sourcemap-loader": "^0.3.8",
     "mocha": "^10.0.0",
     "mocha-junit-reporter": "^2.0.0",
-    "nyc": "^15.0.0",
+    "c8": "^8.0.0",
     "prettier": "^2.5.1",
     "rimraf": "^3.0.0",
     "sinon": "^15.0.0",

diff --git a/sdk/communication/communication-sms/package.json b/sdk/communication/communication-sms/package.json
@@ -103,7 +103,7 @@
     "karma": "^6.2.0",
     "mocha-junit-reporter": "^2.0.0",
     "mocha": "^10.0.0",
-    "nyc": "^15.0.0",
+    "c8": "^8.0.0",
     "prettier": "^2.5.1",
     "rimraf": "^3.0.0",
     "sinon": "^15.0.0",

diff --git a/sdk/communication/communication-tiering/package.json b/sdk/communication/communication-tiering/package.json
@@ -100,7 +100,7 @@
     "karma-sourcemap-loader": "^0.3.8",
     "mocha": "^10.0.0",
     "mocha-junit-reporter": "^2.0.0",
-    "nyc": "^15.0.0",
+    "c8": "^8.0.0",
     "prettier": "^2.5.1",
     "rimraf": "^3.0.0",
     "sinon": "^15.0.0",

diff --git a/sdk/communication/communication-toll-free-verification/package.json b/sdk/communication/communication-toll-free-verification/package.json
@@ -99,7 +99,7 @@
     "karma-sourcemap-loader": "^0.3.8",
     "mocha": "^10.0.0",
     "mocha-junit-reporter": "^2.0.0",
-    "nyc": "^15.0.0",
+    "c8": "^8.0.0",
     "prettier": "^2.5.1",
     "rimraf": "^3.0.0",
     "sinon": "^15.0.0",

diff --git a/sdk/compute/arm-compute-rest/package.json b/sdk/compute/arm-compute-rest/package.json
@@ -100,7 +100,7 @@
     "karma-source-map-support": "~1.4.0",
     "karma-sourcemap-loader": "^0.3.8",
     "karma": "^6.2.0",
-    "nyc": "^15.0.0",
+    "c8": "^8.0.0",
     "@azure/arm-network": "^32.2.0",
     "ts-node": "^10.0.0",
     "esm": "^3.2.18"

diff --git a/sdk/confidentialledger/confidential-ledger-rest/package.json b/sdk/confidentialledger/confidential-ledger-rest/package.json
@@ -104,7 +104,7 @@
     "eslint": "^8.0.0",
     "mocha": "^10.0.0",
     "mocha-junit-reporter": "^2.0.0",
-    "nyc": "^15.0.0",
+    "c8": "^8.0.0",
     "prettier": "^2.5.1",
     "rimraf": "^3.0.0",
     "source-map-support": "^0.5.9",

diff --git a/sdk/containerregistry/container-registry/package.json b/sdk/containerregistry/container-registry/package.json
@@ -115,7 +115,7 @@
     "karma-sourcemap-loader": "^0.3.8",
     "mocha": "^10.0.0",
     "mocha-junit-reporter": "^2.0.0",
-    "nyc": "^15.0.0",
+    "c8": "^8.0.0",
     "prettier": "^2.5.1",
     "rimraf": "^3.0.0",
     "typescript": "~5.0.0",

diff --git a/sdk/containerservice/arm-containerservice-rest/package.json b/sdk/containerservice/arm-containerservice-rest/package.json
@@ -109,7 +109,7 @@
     "karma-source-map-support": "~1.4.0",
     "karma-sourcemap-loader": "^0.3.8",
     "karma": "^6.2.0",
-    "nyc": "^15.0.0",
+    "c8": "^8.0.0",
     "ts-node": "^10.0.0",
     "esm": "^3.2.18"
   },

diff --git a/sdk/contentsafety/ai-content-safety-rest/package.json b/sdk/contentsafety/ai-content-safety-rest/package.json
@@ -100,7 +100,7 @@
     "karma-source-map-support": "~1.4.0",
     "karma-sourcemap-loader": "^0.3.8",
     "karma": "^6.2.0",
-    "nyc": "^15.0.0",
+    "c8": "^8.0.0",
     "@azure/core-util": "^1.4.0",
     "esm": "^3.2.18"
   },

diff --git a/sdk/core/abort-controller/package.json b/sdk/core/abort-controller/package.json
@@ -93,7 +93,7 @@
     "karma-sourcemap-loader": "^0.3.8",
     "mocha": "^10.0.0",
     "mocha-junit-reporter": "^2.0.0",
-    "nyc": "^15.0.0",
+    "c8": "^8.0.0",
     "prettier": "^2.5.1",
     "rimraf": "^3.0.0",
     "ts-node": "^10.0.0",

diff --git a/sdk/core/core-amqp/package.json b/sdk/core/core-amqp/package.json
@@ -105,7 +105,7 @@
     "karma-mocha": "^2.0.1",
     "mocha": "^10.0.0",
     "mocha-junit-reporter": "^2.0.0",
-    "nyc": "^15.0.0",
+    "c8": "^8.0.0",
     "prettier": "^2.5.1",
     "puppeteer": "^19.2.2",
     "rimraf": "^3.0.0",

diff --git a/sdk/core/core-http/package.json b/sdk/core/core-http/package.json
@@ -164,7 +164,7 @@
     "mocha": "^10.0.0",
     "mocha-junit-reporter": "^2.0.0",
     "npm-run-all": "^4.1.5",
-    "nyc": "^15.0.0",
+    "c8": "^8.0.0",
     "prettier": "^2.5.1",
     "puppeteer": "^19.2.2",
     "regenerator-runtime": "^0.13.3",

diff --git a/sdk/core/core-lro/package.json b/sdk/core/core-lro/package.json
@@ -117,7 +117,7 @@
     "karma-sourcemap-loader": "^0.3.8",
     "mocha": "^10.0.0",
     "mocha-junit-reporter": "^2.0.0",
-    "nyc": "^15.0.0",
+    "c8": "^8.0.0",
     "prettier": "^2.5.1",
     "rimraf": "^3.0.0",
     "ts-node": "^10.0.0",

diff --git a/sdk/core/logger/package.json b/sdk/core/logger/package.json
@@ -92,7 +92,7 @@
     "karma-sourcemap-loader": "^0.3.8",
     "mocha": "^10.0.0",
     "mocha-junit-reporter": "^2.0.0",
-    "nyc": "^15.0.0",
+    "c8": "^8.0.0",
     "prettier": "^2.5.1",
     "puppeteer": "^19.2.2",
     "rimraf": "^3.0.0",

diff --git a/sdk/devcenter/developer-devcenter-rest/package.json b/sdk/devcenter/developer-devcenter-rest/package.json
@@ -117,7 +117,7 @@
     "karma-source-map-support": "~1.4.0",
     "karma-sourcemap-loader": "^0.3.8",
     "karma": "^6.2.0",
-    "nyc": "^15.0.0",
+    "c8": "^8.0.0",
     "ts-node": "^10.0.0",
     "esm": "^3.2.18"
   },

diff --git a/sdk/digitaltwins/digital-twins-core/package.json b/sdk/digitaltwins/digital-twins-core/package.json
@@ -22,7 +22,6 @@
     "build:samples": "echo Obsolete.",
     "check-format": "prettier --list-different --config ../../../.prettierrc.json --ignore-path ../../../.prettierignore \"src/**/*.ts\" \"test/**/*.ts\" \"samples-dev/**/*.ts\" \"*.{js,json}\"",
     "clean": "rimraf dist dist-esm dist-browser test-dist test-browser types *.tgz *.log",
-    "coverage": "nyc --reporter=lcov --exclude-after-remap=false mocha -t 120000 dist-test/index.node.js --reporter ../../../common/tools/mocha-multi-reporter.js",
     "execute:js-samples": "node ../../../common/scripts/run-samples.js samples/javascript/",
     "execute:samples": "dev-tool samples run samples-dev",
     "extract-api": "tsc -p . && api-extractor run --local",
@@ -101,7 +100,7 @@
     "karma-sourcemap-loader": "^0.3.8",
     "mocha": "^10.0.0",
     "mocha-junit-reporter": "^2.0.0",
-    "nyc": "^15.0.0",
+    "c8": "^8.0.0",
     "prettier": "^2.5.1",
     "rimraf": "^3.0.0",
     "sinon": "^15.0.0",

diff --git a/sdk/documenttranslator/ai-document-translator-rest/package.json b/sdk/documenttranslator/ai-document-translator-rest/package.json
@@ -118,7 +118,7 @@
     "karma": "^6.2.0",
     "mocha-junit-reporter": "^2.0.0",
     "mocha": "^10.0.0",
-    "nyc": "^15.0.0",
+    "c8": "^8.0.0",
     "prettier": "^2.5.1",
     "rimraf": "^3.0.0",
     "source-map-support": "^0.5.9",

diff --git a/sdk/easm/defender-easm-rest/package.json b/sdk/easm/defender-easm-rest/package.json
@@ -100,7 +100,7 @@
     "mkdirp": "^1.0.4",
     "mocha-junit-reporter": "^2.0.0",
     "mocha": "^10.0.0",
-    "nyc": "^15.0.0",
+    "c8": "^8.0.0",
     "prettier": "^2.5.1",
     "rimraf": "^3.0.0",
     "source-map-support": "^0.5.9",

diff --git a/sdk/entra/functions-authentication-events/package.json b/sdk/entra/functions-authentication-events/package.json
@@ -94,7 +94,7 @@
     "karma-mocha-reporter": "^2.2.5",
     "mocha": "^10.0.0",
     "mocha-junit-reporter": "^2.0.0",
-    "nyc": "^15.0.0",
+    "c8": "^8.0.0",
     "prettier": "^2.5.1",
     "rimraf": "^3.0.0",
     "source-map-support": "^0.5.9",