Update and prepare GA for @azure/web-pubsub-client #27694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zackliu
requested review from
bterlson,
xirzec,
jeremymeng and
vicancy
as code owners
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
joheredi
reviewed
Nov 8, 2023
mpodwysocki
reviewed
Nov 14, 2023
mpodwysocki
reviewed
Nov 17, 2023
mpodwysocki
reviewed
Nov 17, 2023
mpodwysocki
requested changes
Nov 20, 2023
sdk/web-pubsub/web-pubsub-client/review/web-pubsub-client.api.md
Outdated
Show resolved
Hide resolved
mpodwysocki
reviewed
Nov 28, 2023
mpodwysocki
approved these changes
Nov 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Packages impacted by this PR
@azure/web-pubsub-client
Describe the problem that is addressed by this PR
Update according to GA API review: https://apiview.dev/Assemblies/Review/492267bc4ab44b19a558635733047147
What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen?
Are there test cases added in this PR? (If not, why?)
Provide a list of related PRs (if any)
Command used to generate this PR:**(Applicable only to SDK release request PRs)
Checklists