Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rollup-plugin-node-resolve to 5.0.2 #3908

Closed

Conversation

mikeharder
Copy link
Member

This PR updates dev dependency rollup-plugin-node-resolve from ^4.2.0 to ^5.0.2. This is required for compat with [email protected] (rollup/rollup-plugin-node-resolve#222).

This PR was generated by running the following command:

cd sdk\servicebus\service-bus
rush add -p [email protected] --dev --caret --make-consistent

There are two meaningful changes:

  • In all impacted package.json files, dev dependency rollup-plugin-node-resolve was updated from ^4.2.0 to ^5.0.2.
  • pnpm-lock.yaml was updated to the latest matching versions of all floated packages

All other changes should just be re-arranging lines in package.json, which is done automatically by Rush.

CC: @ramya-rao-a, @daviwil, @jonathandturner

Copy link
Contributor

@daviwil daviwil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@mikeharder
Copy link
Member Author

I will need to investigate the test build failures before this can be merged

- Current rollup config is invalid
- Generated browser bundle will fail at runtime
- Build errors block update to rollup-plugin-node-resolve@^5.0.2
@mikeharder mikeharder force-pushed the rollup-plugin-node-resolve branch from 1882482 to bd00e5a Compare June 18, 2019 23:52
@mikeharder mikeharder closed this Jun 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants