-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Text Analytics] Implement IsEnvironmentReadyAsync
#35453
[Text Analytics] Implement IsEnvironmentReadyAsync
#35453
Conversation
API change check API changes are not detected in this pull request. |
/azp run net - textanalytics - tests |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run net - textanalytics - tests |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run net - textanalytics - tests |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run net - textanalytics - tests |
Azure Pipelines successfully started running 1 pipeline(s). |
IsEnvironmentReadyAsync
sdk/textanalytics/Azure.AI.TextAnalytics/tests/Infrastructure/TextAnalyticsTestEnvironment.cs
Show resolved
Hide resolved
sdk/textanalytics/Azure.AI.TextAnalytics/tests/RetryOnInternalServerErrorAttributeTests.cs
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, however, the issue seems to be not TA specific. Should the pipeline add some latency after the resource creation step to mitigate it?
We don't want to add latency to all pipelines. Few, hopefully, need it. See my review for what I suggested to inject latency when needed. |
Resolves: #35452.
Implemented
IsEnvironmentReadyAsync
with a simple request to the dynamic resource to confirm that permissions have propagated successfully, because otherwise we're at risk of having a bunch of test failures like this one:Additionally, while testing, I found another instance of the transient Internal Server Error. The difference is that the message is simply "Internal Server Error." while the previous known case said "Failed to process task after several retry":
I added this one to the
ShouldRetry
method ofRetryOnInternalServerErrorAttribute
.