[Azure Search] Prevent ObjectDisposedException when Indexing using "Merge" operation #7011
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the
DoIndexAsync
method, when the response contains partial success/failure - anIndexBatchException
object is constructed, whose request and response wrapper objects are assigned to the result from the underlying proxy's operation.The request wrapper object attempts to re-read the request content from the underlying proxy's result - this results in the
ObjectDisposedException
when the target framework is .NET Framework 4.xThis is because the
HttpClient
in the .NET framework, automatically disposes the HttpContent once the request is actually sent, whereas theHttpClient
in .NET Core no longer disposes the HttpContentThis pull request adds conditional logic to detect the target framework, and re-serializes the request payload in case the framework is .NET Framework 4.x
Fixes #6910
FYI: @weshaggard