Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing source archives for azure-template on PyPi #29104

Closed
glaubitz opened this issue Mar 2, 2023 · 4 comments
Closed

Missing source archives for azure-template on PyPi #29104

glaubitz opened this issue Mar 2, 2023 · 4 comments
Assignees
Labels
Central-EngSys This issue is owned by the Engineering System team. customer-reported Issues that are reported by GitHub users external to the Azure organization. issue-addressed Workflow: The Azure SDK team believes it to be addressed and ready to close. question The issue doesn't require a change to the product in order to be resolved. Most issues start as that

Comments

@glaubitz
Copy link

glaubitz commented Mar 2, 2023

The latest releases of the azure-template package are missing their source releases on PyPi.

See:

@ghost ghost added customer-reported Issues that are reported by GitHub users external to the Azure organization. question The issue doesn't require a change to the product in order to be resolved. Most issues start as that labels Mar 2, 2023
@github-actions github-actions bot added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Mar 2, 2023
@kristapratico kristapratico added Central-EngSys This issue is owned by the Engineering System team. and removed needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. labels Mar 6, 2023
@ghost ghost added the needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team label Mar 6, 2023
@kristapratico
Copy link
Member

Thanks for the issue @glaubitz, we'll take a look asap.

@scbedd - should we be publishing a src distribution for the azure-template package?

@scbedd
Copy link
Member

scbedd commented Mar 6, 2023

  1. I am pretty impressed someone noticed so quickly. Nice catch @glaubitz !
  2. @kristapratico Template pipeline is intentionally used as a test pipeline. In this case, we were testing a new release process and this exact problem turned into a follow-up issue for the team that owns that new release process. At the end of the day it doesn't truly matter aside from the fact that it is a good smoke-test for our release process in general.
  3. Said ESRP team pushed a fix over the weekend and I'll be testing that momentarily. If everything goes well the next template release should have the source dist again.

I do believe we can close this issue though. Any template release off of main will contain the appropriate files, including sdist etc.

EDIT: follow-up on #3

image

We can definitely call this done now.

@kristapratico kristapratico added issue-addressed Workflow: The Azure SDK team believes it to be addressed and ready to close. and removed needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team labels Mar 6, 2023
@ghost
Copy link

ghost commented Mar 6, 2023

Hi @glaubitz. Thank you for opening this issue and giving us the opportunity to assist. We believe that this has been addressed. If you feel that further discussion is needed, please add a comment with the text “/unresolve” to remove the “issue-addressed” label and continue the conversation.

@ghost
Copy link

ghost commented Mar 14, 2023

Hi @glaubitz, since you haven’t asked that we “/unresolve” the issue, we’ll close this out. If you believe further discussion is needed, please add a comment “/unresolve” to reopen the issue.

@ghost ghost closed this as completed Mar 14, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jun 12, 2023
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Central-EngSys This issue is owned by the Engineering System team. customer-reported Issues that are reported by GitHub users external to the Azure organization. issue-addressed Workflow: The Azure SDK team believes it to be addressed and ready to close. question The issue doesn't require a change to the product in order to be resolved. Most issues start as that
Projects
None yet
Development

No branches or pull requests

3 participants