Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating package release to run through the ESRP release pipeline #29004

Merged
merged 11 commits into from
Apr 3, 2023

Conversation

scbedd
Copy link
Member

@scbedd scbedd commented Feb 24, 2023

Resolves #28160

This PR enables the usage of ESRP Release task for publish to PyPI. SDK Devs don't need to worry about this update, as the release process remains the same.

This PR:

  • Updates our release process to use the ESRP Release task instead of twine upload using our azure-sdk account.
  • On pypi, these packages will be published by the Microsoft account instead of the azure-sdk account.
  • Not reflected in PR, but I also proved out the update to our partner drops pipeline.

Check doc/esrp_release.md for additional detail on break glass scenarios.

@scbedd scbedd added the Central-EngSys This issue is owned by the Engineering System team. label Feb 24, 2023
@scbedd scbedd self-assigned this Feb 24, 2023
@scbedd scbedd changed the title updating release to run through the ESRP release pipeline versus manu… Updating package release to run through the ESRP release pipeline Feb 24, 2023
@scbedd scbedd marked this pull request as ready for review March 6, 2023 19:53
@scbedd scbedd requested review from weshaggard and benbp as code owners March 6, 2023 19:53
@scbedd scbedd requested a review from mccoyp March 6, 2023 23:48
doc/esrp_release.md Outdated Show resolved Hide resolved
Co-authored-by: Ben Broderick Phillips <[email protected]>
@scbedd
Copy link
Member Author

scbedd commented Mar 8, 2023

I also need to adjust this PR to allow the partner release pipeline to use this same strategy. That commit will be added before merge after all the releases have finished up.

@scbedd
Copy link
Member Author

scbedd commented Mar 22, 2023

Commenting old PR body for posterity.

@hallipr @JimSuplizio I basically copy-pasta-ed your configuration from sdk-for-java.

Excepting:

  • Targeting PyPI instead of Maven
  • Using Publisher ESRPRELTEST instead of ESRPRELPACMANTEST as that is what was used in the demo provided to me.

Any gotchas that I should be aware of other than actually running this thing?

EDIT: according to filed icm the ESRP team does not currently support uploading a tar.gz formatted sdist. PR is pending until they support it.

Further EDIT: 3/6/2023 ESRP team got back to me, re-ran the release, zip sdist is present now.

image

@scbedd scbedd merged commit 5da9c93 into main Apr 3, 2023
@scbedd scbedd deleted the use-esrp-release branch April 3, 2023 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Central-EngSys This issue is owned by the Engineering System team.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Transition release process to ESRP Gateway
3 participants