Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first in (I hope) many PRs to remove most of the traits we use internally in Cosmos.
This removes all traits which seek to require client getter methods. I don't see any advantage to these being a part of a trait instead of being on the struct itself. I believe the thought originally behind this was consistent naming, but I think it's easier to manually keep track of that rather than relying on traits (after all, the user could just choose to not implement the trait at all).
I believe we should remove all traits which exist only to enforce naming conventions. I believe this will most likely result in removing the entire
traits.rs
file in Cosmos DB.