-
Notifications
You must be signed in to change notification settings - Fork 260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implemented Event Grid Client & Publish Events #126
Conversation
Implementation for Azure#125
Replicating my comments from #125 here for completeness:
|
Nice job! Thank you! We are migrating towards HTTP client independence (using a very simple trait) but I think we can address it later! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job! 👍 👍
I only ask to simplify the client getting rid of the str
borrows.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Strings are now owned by the EventGridClient rather than borrowed.
Great, that's awesome to hear. I've seen how the trait works in storage for example and how that can be used to make mock clients for nice unit testing and I like that approach a lot. I would have tried to replicate that, but I quickly realised that I was wondering into duplicating a lot of code between the services. |
Thank you! |
Implementation for #125