add support for unions in generated service serialization #1414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cataggar
commented
Sep 21, 2023
demoray
reviewed
Sep 22, 2023
demoray
approved these changes
Sep 25, 2023
This was referenced Oct 1, 2023
Merged
demoray
pushed a commit
that referenced
this pull request
Oct 9, 2023
This fixes a bug from #1414 which causes deserialization to fail. * create the base type without the discriminator * adds the description to the union type * fixes union types for vector aliases * fixes support for nested unions * removes empty base types
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1394. It adds new types with
Unionsuffix added to represent the discriminated unions.