Add support for device identity operations #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rylev
approved these changes
Jan 12, 2021
| /// let iothub = ServiceClient::from_connection_string(connection_string, 3600).expect("Failed to create the ServiceClient!"); | ||
| /// let device = iothub.get_device_identity("some-device"); | ||
| /// ``` | ||
| pub async fn get_device_identity<S>(&self, device_id: S) -> Result<Device, AzureError> |
There was a problem hiding this comment.
These don't really match the pattern of request builders we've been using in other crates. That might be fine, but we probably need to think more deeply about if the iothub crate should follow the same pattern.
There was a problem hiding this comment.
I'd be happy to change it so it's similar to the other crates, no problem at all. I did notice there is a "common" http client within the core crate that was added a while ago. Is this what you mean that should be used instead? Could you link me an example of the ideal way we'd be doing requests?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for getting, creating, updating, and deleting device identities from the IoT Hub and partial implementation for the module identities. I'll add full support for the module identities in a later PR.