Fix #[serde(flatten)] annotation and add ResourceType value #1436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n unknown field it errors. Reason: Deserialization of xml is iffy in regard to XMl. This is due to ambiguous typing. Deserialization will interpret the inner field as a map as opposed to a string, thus resulting in a failed conversion with the #[serde(flatten)] annotation and as such, an error. Fix: Change the map to use serde_json::Value Bug 2: List blobs response occasionally can contain a `ResourceType` field. This isn't deserialized to a public field. Fix: Add the field
|
@microsoft-github-policy-service agree |
CHarrod283
changed the title
storage_blobs::blob::BlobProperties deserializes with a…
cataggar
approved these changes
Oct 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug 1: When
storage_blobs::blob::BlobPropertiesdeserializes with an unknown field it errors.Reason: Deserialization is iffy in regard to XMl. This is due to ambiguous typing. Deserialization will interpret the inner field as a map as opposed to a string, thus resulting in a failed conversion with the #[serde(flatten)] annotation and as such, an error.
Fix: Change the map to use serde_json::Value
Bug 2: List blobs response occasionally can contain a
ResourceTypefield. This isn't deserialized to a public field.Fix: Add the field