Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add union test #1437

Merged
merged 5 commits into from
Oct 10, 2023
Merged

add union test #1437

merged 5 commits into from
Oct 10, 2023

Conversation

cataggar
Copy link
Member

@cataggar cataggar commented Oct 9, 2023 •
edited
Loading

This allows a tests.rs file for a generated service.

It now just adds a union test and adds anyhow as a dev-dependency for services.
This PR does not add the tests to CI. That would be next.

heaths
heaths approved these changes Oct 9, 2023
View reviewed changes
Copy link
Member

@heaths heaths left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine, but just to double check my understanding of why: effectively, it's a file in an otherwise generated location, so you want to move it, regen, then move it back (as well as reference it in lib.rs),yeah?

@cataggar cataggar changed the title allow tests.rs for services allow union test Oct 10, 2023
@cataggar cataggar changed the title allow union test add union test Oct 10, 2023
@demoray demoray merged commit 3d48695 into Azure:main Oct 10, 2023
19 checks passed
@cataggar cataggar deleted the tests branch October 10, 2023 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@demoray demoray demoray left review comments

@heaths heaths heaths approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cataggar @demoray @heaths