Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Url instead of strings #1478

Merged
merged 5 commits into from
Nov 30, 2023
Merged

Use Url instead of strings #1478

merged 5 commits into from
Nov 30, 2023

Conversation

demoray
Copy link
Contributor

@demoray demoray commented Nov 30, 2023

In a number of places, we use &str to pass around Urls. This begins the conversion to use Url directly.

To ease reviews, there are 3 commits in this PR.

  1. Updates to the SDK crates
  2. Updates to the autorust generator
  3. Regenerated crates (and the required updates to the examples)

heaths
heaths approved these changes Nov 30, 2023
View reviewed changes
Copy link
Member

@heaths heaths left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for splitting these up. Made it much easier to review.

.github/workflows/check-all-services.yml Show resolved Hide resolved
@demoray demoray merged commit 6f2cd13 into main Nov 30, 2023
37 checks passed
@demoray demoray deleted the use-url-instead-of-strings branch November 30, 2023 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heaths heaths heaths approved these changes

@cataggar cataggar Awaiting requested review from cataggar

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@demoray @heaths