Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow setting custom properties in service_bus send_message() #1758

Conversation

bryanpendleton
Copy link
Contributor

Following on the recent broker_properties additions, it'd be nice to be able to set custom properties as well.

Copy link
Member

@heaths heaths left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wanted to caution again about adding a lot of functionality to the code currently in main. It is unsupported, and we will be moving it to a new legacy branch soon. I recommend opening tracking issues to make sure you see features in future supported crates. I can't guarantee we will review all unsupported crates to migrate functionality to supported crates as we onboard services.

sdk/messaging_servicebus/src/service_bus/mod.rs Outdated Show resolved Hide resolved
@bryanpendleton bryanpendleton force-pushed the Allow-setting-custom-properties-in-service_bus-send_message() branch from c6f30c3 to 48e0055 Compare August 23, 2024 17:42
@bryanpendleton bryanpendleton force-pushed the Allow-setting-custom-properties-in-service_bus-send_message() branch from 48e0055 to 0366f6f Compare August 23, 2024 17:45
@bryanpendleton
Copy link
Contributor Author

@microsoft-github-policy-service agree company="Fugu UX"

@bryanpendleton
Copy link
Contributor Author

I wanted to caution again about adding a lot of functionality to the code currently in main. It is unsupported, and we will be moving it to a new legacy branch soon. I recommend opening tracking issues to make sure you see features in future supported crates. I can't guarantee we will review all unsupported crates to migrate functionality to supported crates as we onboard services.

Thanks for the heads up! Is there a resource someplace documenting this plan, and how best to contribute? I don't know much about the history of these crates besides noting that they were largely originated from Microsoft but marked unofficial.

@heaths
Copy link
Member

heaths commented Aug 26, 2024

No, but we'll be making changes soon. If you want to see this change in that source, please open a separate tracking issue and reference this PR for context.

In the future, please push new commits so I can review the diff instead of reviewing the entire PR again.

@bryanpendleton
Copy link
Contributor Author

No, but we'll be making changes soon. If you want to see this change in that source, please open a separate tracking issue and reference this PR for context.

In the future, please push new commits so I can review the diff instead of reviewing the entire PR again.

Thanks for the review!

@heaths heaths merged commit b16e879 into Azure:main Aug 28, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants