Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename Crates #34

Merged
merged 9 commits into from
Oct 14, 2020
Merged

Rename Crates #34

merged 9 commits into from
Oct 14, 2020

Conversation

rylev
Copy link
Contributor

@rylev rylev commented Oct 14, 2020 •
edited
Loading

The scheme for sdk crate names is azure_$SERVICE. This means we now have the following crates:

  • azure_core
  • azure_cosmos
  • azure_identity
  • azure_key_vault
  • azure_service_bus
  • azure_storage

ctaggart
ctaggart approved these changes Oct 14, 2020
View reviewed changes
Copy link
Contributor

@ctaggart ctaggart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

scripts/publish_all.sh Outdated Show resolved Hide resolved
sdk/core/Cargo.toml Show resolved Hide resolved
@rylev
Copy link
Contributor Author

rylev commented Oct 14, 2020

I'd like to wait for @ctaggart to approve and merge #10 before me merge this

@rylev rylev merged commit 374e834 into Azure:master Oct 14, 2020
@rylev rylev deleted the crate-renames branch October 14, 2020 16:14
@ctaggart ctaggart mentioned this pull request Oct 15, 2020
Closed
@ctaggart ctaggart mentioned this pull request Jun 16, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ctaggart ctaggart ctaggart approved these changes

@MindFlavor MindFlavor MindFlavor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rylev @ctaggart @MindFlavor