Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename operation configuration to OperationConfig #55

Merged
merged 2 commits into from
Oct 21, 2020

Conversation

ctaggart
Copy link
Contributor

This gives a more description type title and solves a couple of name conflicts. Fixes ctaggart/autorust#65. Adds 7 mgmt services for a total of 107.

@ctaggart
Copy link
Contributor Author

maintenance, mysql, postgresql, keyvault, batch, softwareplan, azure-kusto

@rylev
Copy link
Contributor

rylev commented Oct 21, 2020

FYI: I'm not sure I like this. I've left a comment on the autorust repo as to why: ctaggart/autorust#65 (comment)

@ctaggart
Copy link
Contributor Author

@rylev, I responded there with some more details. I removed use of crate::*, given your feedback in c607d2c. I'd like to merge this.

Copy link
Contributor

@rylev rylev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok I'm fine with this change then. I'm not sure how I feel specifically about the name OperationConfig, but we can go with it for now.

@ctaggart ctaggart merged commit 590213c into Azure:master Oct 21, 2020
@ctaggart ctaggart deleted the OperationConfig branch October 21, 2020 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

other param named configuration
2 participants