Last into_future
#677
Merged
Last into_future
#677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yoshuawuyts
approved these changes
Mar 4, 2022
Comment on lines
-11
to
-21
| impl Request { | ||
| fn new(uri: Uri, method: Method, headers: HeaderMap, body: Body) -> Self { | ||
| Self { | ||
| uri, | ||
| method, | ||
| headers, | ||
| body, | ||
| } | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
Oh, it took me a sec to realize this had just been moved to core/src/request.rs. That seems good.
Comment on lines
-21
to
-22
| const AZURE_VERSION: &str = "2018-12-31"; | ||
|
|
There was a problem hiding this comment.
Where did this go? Has this been replaced by something else?
There was a problem hiding this comment.
This is done in the telemetry_policy now (not a part of this PR). This can be removed since now everything goes through the pipeline and the telemetry policy will be used.
55 tasks
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finishes the work started in #510 moving to a builder style
into_futurepattern.This also completes #290 moving all operations in Cosmos over to the pipeline architecture.