Simplify ConsistencyLevel and CosmosStruct #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guywaldman
reviewed
Nov 19, 2020
Comment on lines
+51
to
+76
| //Account name: localhost:<port> | ||
| //Account key: C2y6yDjf5/R+ob0N8A7Cgv30VRDJIWEHLM+4QDU5DE2nQ9nDuVTqobD4b8mGGyPMbIZnqyMsEcaGQy67XIw/Jw== | ||
| let auth_token = AuthorizationToken::new_master( | ||
| "C2y6yDjf5/R+ob0N8A7Cgv30VRDJIWEHLM+4QDU5DE2nQ9nDuVTqobD4b8mGGyPMbIZnqyMsEcaGQy67XIw/Jw==", | ||
| ).unwrap(); |
There was a problem hiding this comment.
Remove the unwrap? I don't believe we can. Can you explain?
There was a problem hiding this comment.
Never mind, just realized that this was a magic string for the Cosmos DB emulator account key, I thought this was a leftover from debugging. Ignore my silliness 🙃
Small suggestion, feel free to ignore if out of scope for the PR - document and refer to the docs for the emulator. Maybe move that connection string to a const. Might avoid some confusion for the uninitiated like myself.
guywaldman
reviewed
Nov 19, 2020
| } | ||
|
|
||
| impl CloudLocation { | ||
| /// Consumes the location, returning a base URL |
There was a problem hiding this comment.
Minor - but doesn't consume I believe
|
This is great work ❤️ . I think we probably want to merge #79 first since many modifications are probably going to create conflicts. |
thomastaylor312
approved these changes
Nov 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@thomastaylor312 and I are looking into simplifying the
cosmoscrate. This PR contains changes to two types that are indicative of the larger changes we would like to make.In general these changes favor concrete types over traits. Some additional changes I'd like to make include but are not limited to:
CosmosClienttrait and and renameCosmosStructtoCosmosClient.hyper_clientfield ofCosmosStructtoclientand make it aBox<dyn Client>. This is somewhat dependent on other work to abstract the client usage so implementations are not dependent on a particular http implementation.CosmosClient(akaCosmosStruct)