Fix create-pull-request bug #1131
Conversation
chidozieononiwu
force-pushed
the
bugfix/CommonPullRequestScript
branch
from
0c9fdce to
dc3a505
Compare
|
The following pipelines have been queued for testing: |
chidozieononiwu
force-pushed
the
bugfix/CommonPullRequestScript
branch
from
dc3a505 to
60b4768
Compare
|
The following pipelines have been queued for testing: |
chidozieononiwu
force-pushed
the
bugfix/CommonPullRequestScript
branch
from
60b4768 to
742593d
Compare
|
The following pipelines have been queued for testing: |
| @@ -86,4 +86,4 @@ steps: | |||
| -UserReviewers "${{ parameters.GHReviewersVariable }}" | |||
| -TeamReviewers "${{ parameters.GHTeamReviewersVariable }}" | |||
| -Assignees "${{ parameters.GHAssignessVariable }}" | |||
| -CloseAfterOpenForTesting $${{ parameters.CloseAfterOpenForTesting }} | |||
| -CloseAfterOpenForTesting $${{ coalesce(parameters.CloseAfterOpenForTesting, 'false') }} | |||
There was a problem hiding this comment.
Do we need to coalesce given that we default the value to false?
There was a problem hiding this comment.
Yes, unless we go set it for all the ci.yml files. Other wise it will resolve to ' ' at times.
There was a problem hiding this comment.
I'm fine with this change but I am curious what cases would hit this with empty? A pointer would be good.
There was a problem hiding this comment.
So for regular non-test pipelines. Where no parameter is passed to TestPipeline the value here will resolve to ' '
There was a problem hiding this comment.
Why is that? I see on line 22 https://github.com/Azure/azure-sdk-tools/pull/1131/files#diff-2da9c3d63f1a3177d12f9e47cb7a8d973239379a5e86970b335825f663e6c4f1L22 we pass false as a default value so it should be false if nothing is passed.
There was a problem hiding this comment.
Yes, but if you pass a value to this the default will be overridden. So if when ${{ parameter.TestPipeline }} is passed it will override this default value. Right? And in some case that value may resolve to an empty string "".
chidozieononiwu
force-pushed
the
bugfix/CommonPullRequestScript
branch
from
742593d to
6f98b34
Compare
|
The following pipelines have been queued for testing: |
| @@ -35,7 +35,7 @@ function Invoke-GitHubAPIPost { | |||
| else { | |||
| $warning = "{0} with Uri [ $apiURI ] did not fire request because of empty body." -f (Get-PSCallStack)[1].FunctionName | |||
| LogWarning $warning | |||
| exit 0 | |||
| return $null | |||
There was a problem hiding this comment.
I'm ok with this but what prompted this? I'd still like us to fix the callers to not have us ever hit this empty body case.
|
Hello @azure-sdk! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
|
/check-enforcer override |
ghost
merged commit 
Fixes bug introduced in create-pull-request.yml https://dev.azure.com/azure-sdk/internal/_build/results?buildId=584970&view=logs&j=7864f8e6-ba58-5c87-08d3-fc17566432db&t=41709476-b42b-5552-e853-f2ac4a3ad9de Depends on Azure/azure-sdk-for-net#16145 Azure/azure-sdk-for-js#11986 Azure/azure-sdk-for-java#16657 Azure/azure-sdk-for-python#14686
Fixes bug introduced in create-pull-request.yml https://dev.azure.com/azure-sdk/internal/_build/results?buildId=584970&view=logs&j=7864f8e6-ba58-5c87-08d3-fc17566432db&t=41709476-b42b-5552-e853-f2ac4a3ad9de
Depends on
Azure/azure-sdk-for-net#16145
Azure/azure-sdk-for-js#11986
Azure/azure-sdk-for-java#16657
Azure/azure-sdk-for-python#14686