Update common publish task for 1es template pipeline #7705
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benbp
added
the
Central-EngSys
konrad-jamrozik
approved these changes
Feb 20, 2024
weshaggard
reviewed
Feb 23, 2024
| condition: and(succeeded(), ${{ parameters.CustomCondition }}) | ||
| displayName: 'Publish ${{ parameters.ArtifactName }} Artifacts' | ||
| ${{ if parameters.DisplayName }}: |
There was a problem hiding this comment.
Is this necessary? Do we really need a custom display name? Or perhaps we can set the DisplayName to a default value in the parameter definition to avoid the need for an extra condition here.
There was a problem hiding this comment.
I was finding several places where we were doing publishes in the pipeline that had descriptive names that I thought would be useful to preserve. The conflict is preserving the "failed" description, which I also think was useful. I think we have to pick one or the other.
There was a problem hiding this comment.
@weshaggard updated a bit to remove the conditional
|
closing in favor of #7758 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.