Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run publish on failed or succeeded #7810

Merged
merged 5 commits into from
Mar 5, 2024
Merged

Conversation

benbp
Copy link
Member

@benbp benbp commented Mar 4, 2024

No description provided.

@benbp benbp added the Central-EngSys This issue is owned by the Engineering System team. label Mar 4, 2024
@benbp benbp self-assigned this Mar 4, 2024
@benbp benbp requested a review from scbedd March 4, 2024 22:32
@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@@ -23,7 +23,7 @@ steps:
displayName: Set Failed Artifact Name
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my other comment #7758 (comment) I think we can make this one step to set the artifact name.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah excellent

@@ -23,7 +23,7 @@ steps:
displayName: Set Failed Artifact Name

- task: 1ES.PublishPipelineArtifact@1
condition: and(succeeded(), ${{ parameters.CustomCondition }})
condition: and(failedOrSucceeded(), ${{ parameters.CustomCondition }})
Copy link
Member

@scbedd scbedd Mar 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
condition: and(failedOrSucceeded(), ${{ parameters.CustomCondition }})
condition: and(succeededOrFailed(), ${{ parameters.CustomCondition }})

Possible nit? Real break? Not certain.

Ref

@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

Copy link
Member

@scbedd scbedd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

scbedd pushed a commit to Azure/azure-sdk-for-js that referenced this pull request Mar 5, 2024
Sync eng/common directory with azure-sdk-tools for PR
Azure/azure-sdk-tools#7810 See [eng/common
workflow](https://github.com/Azure/azure-sdk-tools/blob/main/eng/common/README.md#workflow)

---------

Co-authored-by: Ben Broderick Phillips <[email protected]>
@benbp
Copy link
Member Author

benbp commented Mar 5, 2024

/check-enforcer override

@benbp benbp merged commit 2038a7b into Azure:main Mar 5, 2024
8 of 10 checks passed
@benbp benbp deleted the benbp/publish-failed branch March 5, 2024 22:53
Write-Host "##vso[task.setvariable variable=PublishArtifactName;]${{ parameters.ArtifactName }}"
}
condition: and(succeededOrFailed(), ${{ parameters.CustomCondition }})
displayName: Set Artifact Name $(Agent.JobStatus)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't expect this variable to actually correctly render as it is runtime computed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Central-EngSys This issue is owned by the Engineering System team.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants