-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run publish on failed or succeeded #7810
Conversation
The following pipelines have been queued for testing: |
@@ -23,7 +23,7 @@ steps: | |||
displayName: Set Failed Artifact Name |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See my other comment #7758 (comment) I think we can make this one step to set the artifact name.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah excellent
@@ -23,7 +23,7 @@ steps: | |||
displayName: Set Failed Artifact Name | |||
|
|||
- task: 1ES.PublishPipelineArtifact@1 | |||
condition: and(succeeded(), ${{ parameters.CustomCondition }}) | |||
condition: and(failedOrSucceeded(), ${{ parameters.CustomCondition }}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
condition: and(failedOrSucceeded(), ${{ parameters.CustomCondition }}) | |
condition: and(succeededOrFailed(), ${{ parameters.CustomCondition }}) |
Possible nit? Real break? Not certain.
The following pipelines have been queued for testing: |
The following pipelines have been queued for testing: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
The following pipelines have been queued for testing: |
Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#7810 See [eng/common workflow](https://github.com/Azure/azure-sdk-tools/blob/main/eng/common/README.md#workflow) --------- Co-authored-by: Ben Broderick Phillips <[email protected]>
/check-enforcer override |
Write-Host "##vso[task.setvariable variable=PublishArtifactName;]${{ parameters.ArtifactName }}" | ||
} | ||
condition: and(succeededOrFailed(), ${{ parameters.CustomCondition }}) | ||
displayName: Set Artifact Name $(Agent.JobStatus) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't expect this variable to actually correctly render as it is runtime computed.
No description provided.