Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Evaluating distill models #3446

Merged
merged 10 commits into from
Dec 18, 2024
Merged

Evaluating distill models #3446

merged 10 commits into from
Dec 18, 2024

Conversation

vis-yadav
Copy link
Contributor

@vis-yadav vis-yadav commented Nov 20, 2024 •
edited by novaturient95
Loading

Description

Checklist

  • I have read the contribution guidelines.
  • I have coordinated with the docs team ([email protected]) if this PR deletes files or changes any file names or file extensions.
  • Pull request includes test coverage for the included changes.
  • This notebook or file is added to the CODEOWNERS file, pointing to the author or the author's team.

@vis-yadav
Copy link
Contributor Author

@microsoft-github-policy-service agree company="Microsoft"

@vis-yadav vis-yadav marked this pull request as ready for review November 25, 2024 05:01
@iamrk04
Copy link
Contributor

iamrk04 commented Nov 26, 2024

I believe it would be great for customers if we could include the code to deploy the distilled model, create the connection, and then submit the evaluation job. The idea is to simplify the customer journey, otherwise they will have to manually deploy the model and manually create connection, which introduces chances of error while doing these operations. All of this can be part of the distillation notebook, post getting the distilled model. What do you think?

iamrk04
iamrk04 previously approved these changes Dec 2, 2024
View reviewed changes
@vis-yadav vis-yadav requested a review from skasturi December 2, 2024 11:35
@vis-yadav
Copy link
Contributor Author

Benchmark validation runs

@vis-yadav vis-yadav merged commit c121f07 into main Dec 18, 2024
6 checks passed
@vis-yadav vis-yadav deleted the vis-yadav/distillation_notebook branch December 18, 2024 04:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sharvin2187 sharvin2187 sharvin2187 left review comments

@novaturient95 novaturient95 novaturient95 approved these changes

@iamrk04 iamrk04 iamrk04 approved these changes

@skasturi skasturi Awaiting requested review from skasturi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vis-yadav @iamrk04 @sharvin2187 @novaturient95