Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Escape strings correctly in snippets #14582

Merged
merged 2 commits into from
Jul 18, 2024
Merged

Escape strings correctly in snippets #14582

merged 2 commits into from
Jul 18, 2024

Conversation

anthony-c-martin
Copy link
Member

@anthony-c-martin anthony-c-martin commented Jul 18, 2024

Use the syntax factory + pretty printer to emit snippets rather than ad-hoc string formatting. This avoids having to deal with edge cases like escaping.

Closes #14578

Microsoft Reviewers: Open in CodeFlow

Copy link
Contributor

github-actions bot commented Jul 18, 2024

Test this change out locally with the following install scripts (Action run 9993989999)

VSCode
  • Mac/Linux
    bash <(curl -Ls https://aka.ms/bicep/nightly-vsix.sh) --run-id 9993989999
  • Windows
    iex "& { $(irm https://aka.ms/bicep/nightly-vsix.ps1) } -RunId 9993989999"
Azure CLI
  • Mac/Linux
    bash <(curl -Ls https://aka.ms/bicep/nightly-cli.sh) --run-id 9993989999
  • Windows
    iex "& { $(irm https://aka.ms/bicep/nightly-cli.ps1) } -RunId 9993989999"

Copy link
Contributor

github-actions bot commented Jul 18, 2024

Dotnet Test Results

    72 files   -     36      72 suites   - 36   24m 15s ⏱️ - 6m 57s
10 957 tests  -     18  10 957 ✅  -     18  0 💤 ±0  0 ❌ ±0 
25 810 runs   - 12 895  25 810 ✅  - 12 895  0 💤 ±0  0 ❌ ±0 

Results for commit 36dc155. ± Comparison against base commit 684e6d4.

♻️ This comment has been updated with latest results.

@anthony-c-martin anthony-c-martin merged commit f1c7212 into main Jul 18, 2024
44 checks passed
@anthony-c-martin anthony-c-martin deleted the ant/issue14578 branch July 18, 2024 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

User defined type doesn't pass single quotes in the key name when being called in VS Code.
3 participants