Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort public registry module version completion items #15400

Merged
merged 3 commits into from
Oct 25, 2024

Conversation

shenglol
Copy link
Contributor

@shenglol shenglol commented Oct 24, 2024

The current sortText is not based on semantic versioning and lacks zero-padding, leading to incorrect client-side module version ordering. This PR resolves those issues.

Before:

image

After:

image

Closes #14530.

Microsoft Reviewers: Open in CodeFlow

Copy link
Contributor

github-actions bot commented Oct 24, 2024

Test this change out locally with the following install scripts (Action run 11526524667)

VSCode
  • Mac/Linux
    bash <(curl -Ls https://aka.ms/bicep/nightly-vsix.sh) --run-id 11526524667
  • Windows
    iex "& { $(irm https://aka.ms/bicep/nightly-vsix.ps1) } -RunId 11526524667"
Azure CLI
  • Mac/Linux
    bash <(curl -Ls https://aka.ms/bicep/nightly-cli.sh) --run-id 11526524667
  • Windows
    iex "& { $(irm https://aka.ms/bicep/nightly-cli.ps1) } -RunId 11526524667"

Copy link
Contributor

github-actions bot commented Oct 24, 2024

Dotnet Test Results

    72 files   -     36      72 suites   - 36   27m 54s ⏱️ - 15m 40s
11 374 tests  -     24  11 374 ✅  -     24  0 💤 ±0  0 ❌ ±0 
26 479 runs   - 13 232  26 479 ✅  - 13 232  0 💤 ±0  0 ❌ ±0 

Results for commit 56ff07d. ± Comparison against base commit 48315b8.

♻️ This comment has been updated with latest results.

}
}

public interface IPublicRegistryModuleIndexClient
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Renaming the interface to match the term module index and to avoid overloading metadata to reduce confusion.

Copy link
Contributor

@StephenWeatherford StephenWeatherford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@shenglol shenglol merged commit 03defaa into main Oct 25, 2024
47 checks passed
@shenglol shenglol deleted the shenglol/sort-module-versions branch October 25, 2024 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Public Registry Module Versions Are Not Ordered From Latest To Oldest
2 participants