Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: refine the orchestration code #237

Merged
merged 6 commits into from
Aug 22, 2022
Merged

feat: refine the orchestration code #237

merged 6 commits into from
Aug 22, 2022

Conversation

ryanzhang-oss
Copy link
Contributor

@ryanzhang-oss ryanzhang-oss commented Aug 18, 2022 •
edited
Loading

Description of your changes

  1. Remove the placement annotation and finalizer.
  2. Persist the union of the (new and old) selected resources in each placement before dispatching the work objects.
  3. Add a requeue for all the placement reconciler loop.
  4. Allow placement to not select any resource/cluster.
  5. Filter events coming from cluster namespace.
  6. Filter clusters based on its status instead of state.
  7. Smart memberCluster trigger selectors, instead of triggering all CRPs
  8. Add more IT coverage
  9. Refactor some code that allows the easy addition of more UT coverages.
  10. Add missing copy right titles
  11. Minor fixes.

I have:

  • Run make reviewable to ensure this PR is ready for review.

How has this code been tested

UT and IT

Special notes for your reviewer

@ryanzhang-oss ryanzhang-oss self-assigned this Aug 18, 2022
@ryanzhang-oss ryanzhang-oss marked this pull request as draft August 18, 2022 19:03
@ryanzhang-oss ryanzhang-oss changed the title Remove annotation feat: refine logics Aug 18, 2022
@ryanzhang-oss ryanzhang-oss changed the title feat: refine logics feat: refine the orchestration code Aug 19, 2022
@ryanzhang-oss ryanzhang-oss marked this pull request as ready for review August 19, 2022 19:22
@ryanzhang-oss ryanzhang-oss requested a review from Fei-Guo August 19, 2022 19:47
Fei-Guo
Fei-Guo reviewed Aug 20, 2022
View reviewed changes
Copy link
Contributor

@Fei-Guo Fei-Guo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LG.

pkg/controllers/clusterresourceplacement/placement_controller.go Outdated Show resolved Hide resolved
pkg/controllers/clusterresourceplacement/work_propagation.go Outdated Show resolved Hide resolved
pkg/controllers/clusterresourceplacement/placement_controller.go Show resolved Hide resolved
pkg/controllers/clusterresourceplacement/placement_controller.go Outdated Show resolved Hide resolved
pkg/controllers/resourcechange/resourcechange_controller.go Outdated Show resolved Hide resolved
@Fei-Guo Fei-Guo merged commit 8b41895 into Azure:main Aug 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fei-Guo Fei-Guo Fei-Guo approved these changes

Assignees

@ryanzhang-oss ryanzhang-oss

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ryanzhang-oss @Fei-Guo