Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: set correct default chart value and refine placement logic #245

Merged
merged 3 commits into from
Aug 26, 2022
Merged

feat: set correct default chart value and refine placement logic #245

merged 3 commits into from
Aug 26, 2022

Conversation

ryanzhang-oss
Copy link
Contributor

@ryanzhang-oss ryanzhang-oss commented Aug 24, 2022 •
edited
Loading

Description of your changes

  1. set the right value in the helm chart
  2. strip kubectl last applied annotation from work
  3. treat "not found" in the named resource/cluster selector as normal to be consistent with the label selector's behavior
  4. Add more tests to cover

I have:

  • Run make reviewable to ensure this PR is ready for review.

How has this code been tested

IT

Special notes for your reviewer

@ryanzhang-oss ryanzhang-oss marked this pull request as draft August 24, 2022 07:31
@ryanzhang-oss ryanzhang-oss changed the title set correct default chart value and refine some logic feat: set correct default chart value and refine some logic Aug 26, 2022
@ryanzhang-oss ryanzhang-oss marked this pull request as ready for review August 26, 2022 09:19
@ryanzhang-oss ryanzhang-oss changed the title feat: set correct default chart value and refine some logic feat: set correct default chart value and refine placement logic Aug 26, 2022
@Fei-Guo Fei-Guo merged commit be06dfc into Azure:main Aug 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fei-Guo Fei-Guo Fei-Guo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ryanzhang-oss @Fei-Guo