feat: Webhook for CRDs #366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Arvindthiru
force-pushed
the
arvindth/fleetWebhook
branch
from
6ea4c89
to
a6eda92
Compare
|
Hi Arvind! I feel that there are a few general issues about this PR, which would be best if we resolve them first. I'll add them below; we can sync at a convenient time to go through them together if you'd like:
|
michaelawyu
reviewed
May 29, 2023
pkg/webhook/customresourcedefinition/customresourcedefinition_webhook.go
Outdated
Show resolved
Hide resolved
michaelawyu
reviewed
May 29, 2023
michaelawyu
reviewed
May 29, 2023
Arvindthiru
force-pushed
the
arvindth/fleetWebhook
branch
2 times, most recently
from
5adb4d6
to
8321d01
Compare
michaelawyu
reviewed
Jun 14, 2023
pkg/webhook/fleetresourcehandler/fleetresourcehandler_webhook.go
Outdated
Show resolved
Hide resolved
michaelawyu
reviewed
Jun 14, 2023
pkg/webhook/fleetresourcehandler/fleetresourcehandler_webhook.go
Outdated
Show resolved
Hide resolved
michaelawyu
reviewed
Jun 14, 2023
pkg/webhook/fleetresourcehandler/fleetresourcehandler_webhook.go
Outdated
Show resolved
Hide resolved
michaelawyu
reviewed
Jun 14, 2023
michaelawyu
reviewed
Jun 14, 2023
michaelawyu
reviewed
Jun 14, 2023
michaelawyu
reviewed
Jun 14, 2023
Arvindthiru
force-pushed
the
arvindth/fleetWebhook
branch
from
25bda04
to
e05e486
Compare
michaelawyu
reviewed
Jun 15, 2023
michaelawyu
reviewed
Jun 15, 2023
|
Hi Arvind! I think everything looks good; for the remaining comments, if you have any concern, please let me know. |
Arvindthiru
force-pushed
the
arvindth/fleetWebhook
branch
from
0f8d5be
to
c2cc3af
Compare
pkg/webhook/fleetresourcehandler/fleetresourcehandler_webhook.go
Outdated
Show resolved
Hide resolved
Arvindthiru
force-pushed
the
arvindth/fleetWebhook
branch
from
24561e6
to
e8ba12e
Compare
ryanzhang-oss
approved these changes
Jun 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Webhook for fleet CRDs
Created a fleet and joined a member cluster and used kusto query to identify users and their groups. Max size of groups for any user was 3.
All users were either part of system:authenticated or system:masters
I have:
make reviewableto ensure this PR is ready for review.How has this code been tested
Added E2E
Special notes for your reviewer