feat: add handleUpdate func for the CRP controller to support v1 API #373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkg/controllers/clusterresourceplacement/placement_controller.go
Outdated
Show resolved
Hide resolved
pkg/controllers/clusterresourceplacement/placement_controller.go
Outdated
Show resolved
Hide resolved
pkg/controllers/clusterresourceplacement/placement_controller.go
Outdated
Show resolved
Hide resolved
pkg/controllers/clusterresourceplacement/placement_controller.go
Outdated
Show resolved
Hide resolved
|
Added a new error type, ErrUnexpectedBehavior The controller will return nil when the error type is ErrUnexpectedBehavior. |
pkg/controllers/clusterresourceplacement/placement_controller.go
Outdated
Show resolved
Hide resolved
ryanzhang-oss
approved these changes
Jun 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Create handleUpdate func for v1 CRP in order to not break the existing e2e tests.
The current handleUpdate func only creates the clusterPolicySnapshot if needed.
I have:
make reviewableto ensure this PR is ready for review.How has this code been tested
Add Unit tests
Special notes for your reviewer
Will add other functionality, eg, create the clusterResourceSnapshot in the coming PR.