feat: scheduler (4/): add status related structs #376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // internalError signals that a plugin has encountered an internal error. | ||
| // Note that this status code is NOT exported; to return an internalError status, use the | ||
| // FromError() call. | ||
| internalError |
There was a problem hiding this comment.
I wonder why is this internal state in the middle of all the states?
There was a problem hiding this comment.
Hi Ryan! This is not an internal state per se, but to indicate that a plugin could not complete its task due to an error. And I couldn't use error due to the name collision :(
zhiying-lin
approved these changes
Jun 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
This PR is part of the PRs that implement the Fleet workload scheduling.
It features some structs for plugins to report their running status.
I have:
make reviewableto ensure this PR is ready for review.How has this code been tested
Special notes for your reviewer