interface: improve API based on feedbacks #394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fei-Guo
reviewed
Jun 22, 2023
michaelawyu
reviewed
Jun 23, 2023
michaelawyu
reviewed
Jun 23, 2023
michaelawyu
reviewed
Jun 23, 2023
michaelawyu
reviewed
Jun 23, 2023
|
Hi Ryan! I think we might need to re-generate the manifests here as well. |
michaelawyu
reviewed
Jun 25, 2023
zhiying-lin
reviewed
Jun 26, 2023
zhiying-lin
reviewed
Jun 27, 2023
zhiying-lin
reviewed
Jun 27, 2023
ryanzhang-oss
force-pushed
the
api-design
branch
from
be073bc to
235c52a
Compare
ryanzhang-oss
force-pushed
the
api-design
branch
from
235c52a to
08f4c18
Compare
circy9
reviewed
Jun 27, 2023
ryanzhang-oss
force-pushed
the
api-design
branch
from
e002c1c to
a53ce1c
Compare
circy9
reviewed
Jun 28, 2023
ryanzhang-oss
force-pushed
the
api-design
branch
from
a6817f8 to
82701bd
Compare
zhiying-lin
reviewed
Jun 28, 2023
| type RollingUpdateConfig struct { | ||
| // The maximum number of clusters that can be unavailable during the rolling update | ||
| // comparing to the desired number of clusters. | ||
| // The desired number equal to the `NumberOfClusters` field when the placement type is `PickN`. |
There was a problem hiding this comment.
Suggested change
| // The desired number equal to the `NumberOfClusters` field when the placement type is `PickN`. | |
| // The desired number equals to the `NumberOfClusters` field when the placement type is `PickN`. |
| // The maximum number of clusters that can be unavailable during the rolling update | ||
| // comparing to the desired number of clusters. | ||
| // The desired number equal to the `NumberOfClusters` field when the placement type is `PickN`. | ||
| // The desired number equal to the number of clusters scheduler selected when the placement type is `PickAll`. |
There was a problem hiding this comment.
Suggested change
| // The desired number equal to the number of clusters scheduler selected when the placement type is `PickAll`. | |
| // The desired number equals to the number of clusters scheduler selected when the placement type is `PickAll`. |
Comment on lines
54
to
60
| BindingStateScheduled BindingState = "Scheduled" | ||
|
|
||
| // BindingStateBound means the binding is bound to the target cluster. | ||
| BindingStateBound BindingState = "Bound" | ||
|
|
||
| // BindingStateUnScheduled means the binding is not scheduled on to the target cluster anymore. | ||
| BindingStateUnScheduled BindingState = "UnScheduled" |
There was a problem hiding this comment.
hi ryan, could you clarify that, scheduled = creating, bound = active, unscheduled = deleting?
is my understanding correct?
| MaxUnavailable *intstr.IntOrString `json:"maxUnavailable,omitempty"` | ||
|
|
||
| // The maximum number of clusters that can be scheduled above the desired number of clusters. | ||
| // The desired number equal to the `NumberOfClusters` field when the placement type is `PickN`. |
There was a problem hiding this comment.
Suggested change
| // The desired number equal to the `NumberOfClusters` field when the placement type is `PickN`. | |
| // The desired number equals to the `NumberOfClusters` field when the placement type is `PickN`. |
|
|
||
| // The maximum number of clusters that can be scheduled above the desired number of clusters. | ||
| // The desired number equal to the `NumberOfClusters` field when the placement type is `PickN`. | ||
| // The desired number equal to the number of clusters scheduler selected when the placement type is `PickAll`. |
There was a problem hiding this comment.
Suggested change
| // The desired number equal to the number of clusters scheduler selected when the placement type is `PickAll`. | |
| // The desired number equals to the number of clusters scheduler selected when the placement type is `PickAll`. |
| // has passed after the resources are applied to the target cluster successfully. | ||
| // Default is 60. | ||
| // +optional | ||
| UnavailablePeriodSeconds *int `json:"waitBetweenRollingPeriodSeconds,omitempty"` |
There was a problem hiding this comment.
Suggested change
| UnavailablePeriodSeconds *int `json:"waitBetweenRollingPeriodSeconds,omitempty"` | |
| UnavailablePeriodSeconds *int `json:"unavailablePeriodSeconds,omitempty"` |
Co-authored-by: Zhiying Lin <[email protected]>
Co-authored-by: Zhiying Lin <[email protected]>
Co-authored-by: Zhiying Lin <[email protected]>
circy9
previously approved these changes
Jun 28, 2023
michaelawyu
approved these changes
Jun 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Update the API based on the design feedbacks.
Fixes #
I have:
make reviewableto ensure this PR is ready for review.How has this code been tested
Special notes for your reviewer