feat: create a policy snapshot watcher for CRP controller #401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanzhang-oss
approved these changes
Jun 29, 2023
| */ | ||
|
|
||
| // Package clustershedulingpolicysnapshot features a controller to reconcile the clusterSchedulingPolicySnapshot object. | ||
| package clustershedulingpolicysnapshot |
There was a problem hiding this comment.
nit: is this a controller or a watcher? do we need the long file name?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
When clusterSchedulingPolicySnapshot changes, will add a key into the CRP queue.
I have:
make reviewableto ensure this PR is ready for review.How has this code been tested
Will add the integration test in the next PR
Special notes for your reviewer