Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add integration tests for crp watcher #416

Merged
merged 1 commit into from
Jul 6, 2023
Merged

test: add integration tests for crp watcher #416

merged 1 commit into from
Jul 6, 2023

Conversation

zhiying-lin
Copy link
Contributor

Description of your changes

  • add integration tests for crp watcher
  • Minor fix of the schedulingpolicysnapshot controller integration tests

Fixes #

I have:

  • Run make reviewable to ensure this PR is ready for review.

How has this code been tested

integration tests

Special notes for your reviewer

michaelawyu
michaelawyu approved these changes Jul 5, 2023
View reviewed changes
Copy link
Contributor

@michaelawyu michaelawyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A nit for readability; others LGTM.

@zhiying-lin zhiying-lin merged commit 091ccc8 into Azure:main Jul 6, 2023
@zhiying-lin zhiying-lin deleted the crp-it branch July 6, 2023 02:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelawyu michaelawyu michaelawyu approved these changes

@ryanzhang-oss ryanzhang-oss Awaiting requested review from ryanzhang-oss

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zhiying-lin @michaelawyu