Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: enforce revisionHistoryLimit for resource snapshots #426

Merged
merged 5 commits into from
Jul 14, 2023
Merged

feat: enforce revisionHistoryLimit for resource snapshots #426

merged 5 commits into from
Jul 14, 2023

Conversation

zhiying-lin
Copy link
Contributor

Description of your changes

  • delete redundant resourceSnapshots before creating one
  • add the NumberOfResourceSnapshots annotation

Fixes #

I have:

  • Run make reviewable to ensure this PR is ready for review.

How has this code been tested

UT

Special notes for your reviewer

@ryanzhang-oss
Copy link
Contributor

Can we delete a snapshot that still has bindings pointing to it?

@michaelawyu
Copy link
Contributor

Other than the comments, everything LGTM ;)

michaelawyu
michaelawyu approved these changes Jul 14, 2023
View reviewed changes
Copy link
Contributor

@michaelawyu michaelawyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@zhiying-lin zhiying-lin merged commit 3f37a3a into Azure:main Jul 14, 2023
@zhiying-lin zhiying-lin deleted the resource-cleanup branch July 14, 2023 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryanzhang-oss ryanzhang-oss ryanzhang-oss left review comments

@michaelawyu michaelawyu michaelawyu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zhiying-lin @ryanzhang-oss @michaelawyu