feat: add print column to show member agent HB #872
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanzhang-oss
approved these changes
Jul 4, 2024
zhiying-lin
reviewed
Jul 4, 2024
| @@ -17,6 +17,7 @@ import ( | |||
| // +kubebuilder:subresource:status | |||
| // +kubebuilder:printcolumn:JSONPath=`.status.conditions[?(@.type=="Joined")].status`,name="Joined",type=string | |||
| // +kubebuilder:printcolumn:JSONPath=`.metadata.creationTimestamp`,name="Age",type=date | |||
| // +kubebuilder:printcolumn:JSONPath=`.status.agentStatus[?(@.type=="MemberAgent")].lastReceivedHeartbeat`,name="Time-Since-Last-Heartbeat",type=date | |||
There was a problem hiding this comment.
The field name does not indicate the data is from member-agent.
We actually have networking agent running as well.
It may confuse customer.
There was a problem hiding this comment.
We thought about adding all agents. There are a few problems.
- The naming becomes very long for each agent HB.
- The number of columns becomes very long too.
- The network agent may not be installed in some setup and there is no way to do conditional column as we know
Any thoughts?
There was a problem hiding this comment.
I'm thinking of only showing the heartbeat from member-agent by default.
How about naming as "Seen-Member-Agent-At"?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Fixes #
I have:
make reviewableto ensure this PR is ready for review.How has this code been tested
Special notes for your reviewer
ran make manifests