feat: add take over and drift detection options in CRP API #903
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanzhang-oss
force-pushed
the
take-over-drift-api
branch
2 times, most recently
from
e029576
to
8446e9d
Compare
zhiying-lin
reviewed
Aug 14, 2024
ryanzhang-oss
force-pushed
the
take-over-drift-api
branch
2 times, most recently
from
9de8b3b
to
a8beaed
Compare
michaelawyu
reviewed
Aug 15, 2024
zhiying-lin
reviewed
Aug 15, 2024
zhiying-lin
reviewed
Aug 16, 2024
ryanzhang-oss
changed the title
circy9
reviewed
Aug 16, 2024
circy9
reviewed
Aug 16, 2024
ryanzhang-oss
force-pushed
the
take-over-drift-api
branch
from
9218713
to
428f344
Compare
zhiying-lin
reviewed
Aug 26, 2024
michaelawyu
reviewed
Aug 26, 2024
michaelawyu
reviewed
Aug 26, 2024
| // +kubebuilder:default=AlwaysApply | ||
| // +kubebuilder:validation:Enum=AlwaysApply;ApplyIfNoDiff | ||
| // +optional | ||
| TakeoverAction TakeOverActionType `json:"actionType,omitempty"` |
There was a problem hiding this comment.
Does TakeoverAction have no impact if ApplyStrategyType is set to ReportDiff?
There was a problem hiding this comment.
yes, the ApplyStrategyType determines the action
|
A side note: will reach to the customer asking for this feature to confirm on their use cases |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Fixes #
I have:
make reviewableto ensure this PR is ready for review.How has this code been tested
Special notes for your reviewer