feat: add cloudConfig support in member-agent #939
Conversation
britaniar
force-pushed
the
cloudConfig
branch
2 times, most recently
from
b6ae16f
to
27aa8f2
Compare
britaniar
changed the title
cmd/memberagent/main.go
Outdated
| @@ -317,7 +320,7 @@ func Start(ctx context.Context, hubCfg, memberConfig *rest.Config, hubOpts, memb | |||
| discoverClient := discovery.NewDiscoveryClientForConfigOrDie(memberConfig) | |||
|
|
|||
| if *enableV1Alpha1APIs { | |||
| gvk := workv1alpha1.SchemeGroupVersion.WithKind(workv1alpha1.AppliedWorkKind) | |||
| gvk := schema.GroupVersionKind{Group: workv1alpha1.GroupVersion.Group, Version: workv1alpha1.GroupVersion.Version, Kind: workv1alpha1.AppliedWorkKind} | |||
There was a problem hiding this comment.
just curious why we need this change?
There was a problem hiding this comment.
Said it was deprecated
There was a problem hiding this comment.
got it, we can do the refactor in a separate PR.
Since it's about v1alpha1 feature, it's not required cause we will deprecate v1alpha1 API.
| @@ -69,6 +70,9 @@ type PropertyProvider struct { | |||
| // The controller manager in use by the Azure property provider; this field is mostly reserved for | |||
| // testing purposes. | |||
| mgr ctrl.Manager | |||
|
|
|||
| // The cloud configuration in use by the Azure property provider. | |||
| cloudConfig cloudconfig.CloudConfig | |||
There was a problem hiding this comment.
what you need is an azure client. It's better to initialize the client in the main func, so that it can be shared by the whole component.
here we don't need to pass in the whole cloudConfig
There was a problem hiding this comment.
Would that mean we would initialize all the clients we needed too? I also need armnetwork.NewVirtualNetworksClient
Which is why I wanted to originally pass it.
There was a problem hiding this comment.
yes, passing all the clients if needed.
pkg/propertyprovider/azure/cloudconfig/test/azure_valid_config.yaml
Outdated
Show resolved
Hide resolved
britaniar
force-pushed
the
cloudConfig
branch
from
8d9b392
to
c3679c2
Compare
britaniar
force-pushed
the
cloudConfig
branch
from
37fbf1a
to
f626124
Compare
britaniar
force-pushed
the
cloudConfig
branch
from
25112d1
to
90599f7
Compare
britaniar
force-pushed
the
cloudConfig
branch
from
677edf3
to
d26c8fe
Compare
|
LGTM, thanks :) |
britaniar
force-pushed
the
cloudConfig
branch
from
2f9585f
to
ffc0979
Compare
Description of your changes
Fixes #
I have: updated helm chart for member-agent to support cloud config
make reviewableto ensure this PR is ready for review.How has this code been tested
Special notes for your reviewer