Disable shared key access on test storage account #619
+25
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arsing
previously approved these changes
Jun 17, 2024
|
Disabling shared key access on the storage account breaks the Azure Functions app we deploy to host a DPS custom allocation policy. There is apparently a way to run the Azure Functions app with storage keys disabled (using an identity), but it seems to require a labrynth of settings and workarounds. It may take some time to get this all sorted out. |
damonbarry
dismissed
arsing’s stale review
I've added lots of code since this approval, and there's more work to do
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We create a temporary storage account for use by an Azure Function in the scheduled and manual end-to-end tests. Per best practices, we want to create it with shared key access disabled. This change updates the Azure CLI command that creates the storage account.